You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "plusplusjiajia (via GitHub)" <gi...@apache.org> on 2026/04/19 02:27:09 UTC
[PR] build: check in Cargo.lock [paimon-rust]
plusplusjiajia opened a new pull request, #265:
URL: https://github.com/apache/paimon-rust/pull/265
### Purpose
Committing `Cargo.lock` is no longer considered an antipattern for libraries: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
Peer ASF project apache/opendal also commits its lockfile.
paimon-rust is a mixed workspace producing distributable artifacts (`bindings/c` cdylib+staticlib, `bindings/python` cdylib used by pypaimon_rust, consumed by `bindings/go`), so a committed lockfile guarantees reproducible builds of those artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: check in Cargo.lock [paimon-rust]
Posted by "plusplusjiajia (via GitHub)" <gi...@apache.org>.
plusplusjiajia commented on PR #265:
URL: https://github.com/apache/paimon-rust/pull/265#issuecomment-4275210745
Thanks for the review, @JingsongLi ! Makes sense, closing this. Fair points on the library convention and maintenance burden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: check in Cargo.lock [paimon-rust]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #265:
URL: https://github.com/apache/paimon-rust/pull/265#issuecomment-4275073265
As a library crate, paimon-rust generally doesn't commit `Cargo.lock`. The official Rust documentation also recommends this. If the team wants reproducible CI, commits need to be updated regularly with `cargo.lock`, which adds an extra maintenance burden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: check in Cargo.lock [paimon-rust]
Posted by "plusplusjiajia (via GitHub)" <gi...@apache.org>.
plusplusjiajia closed pull request #265: build: check in Cargo.lock
URL: https://github.com/apache/paimon-rust/pull/265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org