You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by "DevinLeamy (via GitHub)" <gi...@apache.org> on 2024/01/16 18:48:56 UTC
[PR] Add XFS quota headroom config flag. [mesos]
DevinLeamy opened a new pull request, #464:
URL: https://github.com/apache/mesos/pull/464
Introduces flags to configurate enable XFS quotas and XFS quota headroom.
- `xfs_enable_quota`: Enable XFS project quotas on the filesystem.
- `xfs_quota_headroom`: The size of hard XFS quota headroom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add XFS quota headroom config flag. [mesos]
Posted by "DevinLeamy (via GitHub)" <gi...@apache.org>.
DevinLeamy commented on code in PR #464:
URL: https://github.com/apache/mesos/pull/464#discussion_r1456588920
##########
src/slave/flags.hpp:
##########
@@ -203,6 +203,8 @@ class Flags : public virtual logging::Flags
#if ENABLE_XFS_DISK_ISOLATOR
std::string xfs_project_range;
bool xfs_kill_containers;
+ bool xfs_enable_quotas;
Review Comment:
There isn't any usage, good catch. The port has been removed and a new patch (https://github.com/apache/mesos/pull/475) will serve to replace the intention behind the flag (i.e. enabling the enforcement of XFS quotas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add XFS quota headroom config flag. [mesos]
Posted by "DevinLeamy (via GitHub)" <gi...@apache.org>.
DevinLeamy commented on PR #464:
URL: https://github.com/apache/mesos/pull/464#issuecomment-1894628923
> Be sure to squash the extra commit.
Squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add XFS quota headroom config flag. [mesos]
Posted by "cf-natali (via GitHub)" <gi...@apache.org>.
cf-natali commented on code in PR #464:
URL: https://github.com/apache/mesos/pull/464#discussion_r1455431207
##########
src/slave/containerizer/mesos/isolators/xfs/disk.cpp:
##########
@@ -223,14 +224,16 @@ XfsDiskIsolatorProcess::XfsDiskIsolatorProcess(
xfs::QuotaPolicy _quotaPolicy,
const std::string& _workDir,
const IntervalSet<prid_t>& projectIds,
- Duration _projectWatchInterval)
+ Duration _projectWatchInterval,
+ const Bytes& _quotaHeadroom)
Review Comment:
Any reason to pass it by const reference instead of value?
I'd assume `Bytes`must be at most a word or two, and seems to be passed by value elsewhere.
##########
src/slave/flags.hpp:
##########
@@ -203,6 +203,8 @@ class Flags : public virtual logging::Flags
#if ENABLE_XFS_DISK_ISOLATOR
std::string xfs_project_range;
bool xfs_kill_containers;
+ bool xfs_enable_quotas;
Review Comment:
I'm probably missing something but I can't see anything using `xfs_enable_quotas`?
##########
src/tests/containerizer/xfs_quota_tests.cpp:
##########
@@ -892,6 +892,94 @@ TEST_F(ROOT_XFS_QuotaTest, VolumeUsageExceedsQuotaWithKill)
}
+// Verify that a task that tries to consme more disk space than it has requested
Review Comment:
Typo: `consme`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add XFS quota headroom config flag. [mesos]
Posted by "DevinLeamy (via GitHub)" <gi...@apache.org>.
DevinLeamy commented on code in PR #464:
URL: https://github.com/apache/mesos/pull/464#discussion_r1455935836
##########
src/slave/containerizer/mesos/isolators/xfs/disk.cpp:
##########
@@ -223,14 +224,16 @@ XfsDiskIsolatorProcess::XfsDiskIsolatorProcess(
xfs::QuotaPolicy _quotaPolicy,
const std::string& _workDir,
const IntervalSet<prid_t>& projectIds,
- Duration _projectWatchInterval)
+ Duration _projectWatchInterval,
+ const Bytes& _quotaHeadroom)
Review Comment:
I see no reason. As you point out, `Bytes` is small so I've updated the argument to pass by value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add XFS quota headroom config flag. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on PR #464:
URL: https://github.com/apache/mesos/pull/464#issuecomment-1894613576
Be sure to squash the extra commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add XFS quota headroom config flag. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler merged PR #464:
URL: https://github.com/apache/mesos/pull/464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org