[GitHub] [incubator-streampark] macksonmu commented on a diff in pull request #2100: [Bug] flink cluster management bug fixed

[GitBox <gi...@apache.org>]

macksonmu commented on code in PR #2100:
URL: https://github.com/apache/incubator-streampark/pull/2100#discussion_r1033057938


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/mapper/ApplicationMapper.java:
##########
@@ -57,4 +57,6 @@ public interface ApplicationMapper extends BaseMapper<Application> {
     Boolean existsByJobName(@Param("jobName") String jobName);
 
     List<Application> getByProjectId(@Param("projectId") Long id);
+
+    boolean existsRunningJobByClusterId(@Param("clusterId")Long clusterId);

Review Comment:
   missing space before `Long`



##########
streampark-console/streampark-console-service/src/main/resources/mapper/core/ApplicationMapper.xml:
##########
@@ -98,6 +99,14 @@
         limit 1
     </select>
 
+    <select id="existsRunningJobByClusterId" resultType="java.lang.Boolean" parameterType="java.lang.Long">
+        select count(1)
+        from t_flink_app
+        where flink_cluster_id = #{clusterId}

Review Comment:
   I didn't understand, what is the difference between `cluster_id` and `flink_cluster_id`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org