You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/13 11:10:24 UTC
[GitHub] [skywalking] xu1009 opened a new pull request #8425: Support ZGC
xu1009 opened a new pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<8411>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8425: Support ZGC metric is OAP and UI
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425#issuecomment-1012131337
Notice, the UI template updates may be reset in the near future, as the 9.0.0 UI uses a different template structure.
Welcome back to recheck when it is ready on Mar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #8425: Support ZGC metric is OAP and UI
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #8425: Support ZGC metric is OAP and UI
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425#issuecomment-1012707169
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8425: Support ZGC
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425#issuecomment-1012104833
This error usually means the docker-compose can't bootstrap. Could you try the docker image locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8425: Support ZGC
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425#discussion_r783949096
##########
File path: oap-server/server-starter/src/main/resources/oal/java-agent.oal
##########
@@ -24,8 +24,10 @@ instance_jvm_memory_heap_max = from(ServiceInstanceJVMMemory.max).filter(heapSta
instance_jvm_memory_noheap_max = from(ServiceInstanceJVMMemory.max).filter(heapStatus == false).longAvg();
instance_jvm_young_gc_time = from(ServiceInstanceJVMGC.time).filter(phase == GCPhase.NEW).sum();
instance_jvm_old_gc_time = from(ServiceInstanceJVMGC.time).filter(phase == GCPhase.OLD).sum();
+instance_jvm_normal_gc_time = from(ServiceInstanceJVMGC.time).filter(phrase == GCPhase.NORMAL).sum();
instance_jvm_young_gc_count = from(ServiceInstanceJVMGC.count).filter(phase == GCPhase.NEW).sum();
instance_jvm_old_gc_count = from(ServiceInstanceJVMGC.count).filter(phase == GCPhase.OLD).sum();
+instance_jvm_normal_gc_count = from(ServiceInstanceJVMGC.count).filter(phrase == GCPhase.NORMAL).sum();
Review comment:
```suggestion
instance_jvm_normal_gc_time = from(ServiceInstanceJVMGC.time).filter(phase == GCPhase.NORMAL).sum();
instance_jvm_young_gc_count = from(ServiceInstanceJVMGC.count).filter(phase == GCPhase.NEW).sum();
instance_jvm_old_gc_count = from(ServiceInstanceJVMGC.count).filter(phase == GCPhase.OLD).sum();
instance_jvm_normal_gc_count = from(ServiceInstanceJVMGC.count).filter(phase == GCPhase.NORMAL).sum();
```
You forget to change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #8425: Support ZGC
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #8425:
URL: https://github.com/apache/skywalking/pull/8425#issuecomment-1012066861
it is still failed, the error message is strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org