You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2013/06/14 21:10:45 UTC
svn commit: r1493213 -
/commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java
Author: britter
Date: Fri Jun 14 19:10:45 2013
New Revision: 1493213
URL: http://svn.apache.org/r1493213
Log:
Apply compose method instead of using comments
Modified:
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java
Modified: commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java
URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java?rev=1493213&r1=1493212&r2=1493213&view=diff
==============================================================================
--- commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java (original)
+++ commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java Fri Jun 14 19:10:45 2013
@@ -249,28 +249,37 @@ public class ConfigRuleSet extends RuleS
* should be added.
*/
public void addRuleInstances(Digester digester) {
- // Add rules for a catalog element
+ addCatalogRules(digester);
+ addChainRules(digester);
+ addCommandRules(digester);
+ addDefineElementRule(digester);
+ }
+
+ private void addCatalogRules(Digester digester) {
digester.addRule("*/" + getCatalogElement(),
- new ConfigCatalogRule(nameAttribute, catalogClass));
+ new ConfigCatalogRule(nameAttribute, catalogClass));
digester.addSetProperties("*/" + getCatalogElement());
+ }
- // Add rules for a chain element
+ private void addChainRules(Digester digester) {
digester.addObjectCreate("*/" + getChainElement(),
- getChainClass(),
- getClassAttribute());
+ getChainClass(),
+ getClassAttribute());
digester.addSetProperties("*/" + getChainElement());
digester.addRule("*/" + getChainElement(),
- new ConfigRegisterRule(nameAttribute));
+ new ConfigRegisterRule(nameAttribute));
+ }
- // Add rules for a command element
+ private void addCommandRules(Digester digester) {
digester.addObjectCreate("*/" + getCommandElement(),
- null,
- getClassAttribute());
+ null,
+ getClassAttribute());
digester.addSetProperties("*/" + getCommandElement());
digester.addRule("*/" + getCommandElement(),
- new ConfigRegisterRule(nameAttribute));
+ new ConfigRegisterRule(nameAttribute));
+ }
- // Add rules for a define element
+ private void addDefineElementRule(Digester digester) {
digester.addRule("*/" + getDefineElement(),
new ConfigDefineRule(getNameAttribute(),
getClassAttribute()));