[GitHub] [incubator-eventmesh] ruanwenjun commented on a diff in pull request #884: [ISSUE-883] Transitively export the dependencies of [eventmesh-sdk-java] to other module

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #884:
URL: https://github.com/apache/incubator-eventmesh/pull/884#discussion_r882250604


##########
eventmesh-sdk-java/build.gradle:
##########
@@ -50,10 +54,9 @@ dependencies {
     implementation "io.grpc:grpc-protobuf:1.15.0"
     implementation "io.grpc:grpc-stub:1.15.0"
     implementation "com.google.protobuf:protobuf-java-util:3.5.1"
-    compileOnly 'org.projectlombok:lombok:1.18.22'
+    api 'org.projectlombok:lombok:1.18.22'

Review Comment:
   In my knowledge, the lombok plugin will only be used in compile time.
   ```suggestion
       compileOnly 'org.projectlombok:lombok:1.18.22'
   ```



##########
eventmesh-sdk-java/build.gradle:
##########
@@ -15,10 +15,14 @@
  * limitations under the License.
  */
 
+plugins {
+    id 'java-library'
+}
+

Review Comment:
   It seems this already defined at root `build.gradle`
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org