You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Bikas Saha (JIRA)" <ji...@apache.org> on 2014/10/29 23:17:34 UTC

[jira] [Updated] (TEZ-1699) Vertex.setParallelism should throw an exception for invalid invocations

     [ https://issues.apache.org/jira/browse/TEZ-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bikas Saha updated TEZ-1699:
----------------------------
    Attachment: TEZ-1699.1.patch

Removes the boolean return value and throws exceptions instead. Tests added. Marked incompatible. AFAIK noone uses the return value. So its best to remove it now.

[~sseth] [~hitesh] Please review.

> Vertex.setParallelism should throw an exception for invalid invocations
> -----------------------------------------------------------------------
>
>                 Key: TEZ-1699
>                 URL: https://issues.apache.org/jira/browse/TEZ-1699
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Priority: Critical
>         Attachments: TEZ-1699.1.patch
>
>
> There is a return value of false when setParallelism is not successful. However that may be ignored and in some cases the invocation is actually incorrect and its better to throw an exception than return false. Throwing an unchecked exception can allow doing this compatibly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)