You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "qy-liuhuo (via GitHub)" <gi...@apache.org> on 2024/10/13 09:31:05 UTC
[PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
qy-liuhuo opened a new pull request, #11351:
URL: https://github.com/apache/inlong/pull/11351
<!-- Prepare a Pull Request
Change the title of pull request refer to the following example:
[INLONG-XYZ][Component] Title of the pull request
-->
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #11349
### Motivation
Integrate opentelemetry for：
- sort-connector-iceberg-v1.15
- sort-connector-kafka-v1.15
- sort-connector-mysql-cdc-v1.15
- sort-connector-pulsar-v1.15
Some connectors that do not conform to the FLIP-27 have not yet been integrated
### Modifications
Integrate opentelemetry for iceberg
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "qy-liuhuo (via GitHub)" <gi...@apache.org>.
qy-liuhuo commented on PR #11351:
URL: https://github.com/apache/inlong/pull/11351#issuecomment-2425694927
When integrating sort-connector-kafka-v1.15 and sort-connector-pulsar-v1.15, the unit test fails. I currently think it is a Maven dependency issue, which I will try to resolve later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang merged PR #11351:
URL: https://github.com/apache/inlong/pull/11351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "qy-liuhuo (via GitHub)" <gi...@apache.org>.
qy-liuhuo commented on code in PR #11351:
URL: https://github.com/apache/inlong/pull/11351#discussion_r1808166758
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/source/reader/KafkaSourceReader.java:
##########
@@ -87,6 +90,22 @@ public KafkaSourceReader(
"Offset commit on checkpoint is disabled. "
+ "Consuming offset will not be reported back to Kafka cluster.");
}
+ this.openTelemetryLogger = new OpenTelemetryLogger.Builder()
+ .setLogLevel(Level.ERROR)
+ .setServiceName(this.getClass().getSimpleName())
+ .setLocalHostIp(this.context.getLocalHostName()).build();
+ }
+
+ @Override
+ public void start() {
+ this.openTelemetryLogger.install();
+ super.start();
+ }
+
+ @Override
+ public void close() throws Exception {
+ super.close();
+ openTelemetryLogger.uninstall(); // 关闭日志上报功能
Review Comment:
Ok, I will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #11351:
URL: https://github.com/apache/inlong/pull/11351#issuecomment-2495791321
Thanks for your contribution.
Sorry, but If we don't use the open telemetry, why do we initialize it in the open method?
Maybe add a new configuration to enable open telemetry is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #11351:
URL: https://github.com/apache/inlong/pull/11351#discussion_r1808162138
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/source/reader/KafkaSourceReader.java:
##########
@@ -87,6 +90,22 @@ public KafkaSourceReader(
"Offset commit on checkpoint is disabled. "
+ "Consuming offset will not be reported back to Kafka cluster.");
}
+ this.openTelemetryLogger = new OpenTelemetryLogger.Builder()
+ .setLogLevel(Level.ERROR)
+ .setServiceName(this.getClass().getSimpleName())
+ .setLocalHostIp(this.context.getLocalHostName()).build();
+ }
+
+ @Override
+ public void start() {
+ this.openTelemetryLogger.install();
+ super.start();
+ }
+
+ @Override
+ public void close() throws Exception {
+ super.close();
+ openTelemetryLogger.uninstall(); // 关闭日志上报功能
Review Comment:
please use the English comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "qy-liuhuo (via GitHub)" <gi...@apache.org>.
qy-liuhuo commented on PR #11351:
URL: https://github.com/apache/inlong/pull/11351#issuecomment-2531585839
> Thanks for your contribution. Sorry, but If we don't use the open telemetry, why do we initialize it in the open method? Maybe adding a new configuration to enable open telemetry is better?
I have finished it, now we can control whether to enable log reporting through command line parameters when submitting flink tasks. Just add ` --enable.log.report true ` when submitting the task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 [inlong]
Posted by "qy-liuhuo (via GitHub)" <gi...@apache.org>.
qy-liuhuo commented on PR #11351:
URL: https://github.com/apache/inlong/pull/11351#issuecomment-2505302421
> Thanks for your contribution. Sorry, but If we don't use the open telemetry, why do we initialize it in the open method? Maybe adding a new configuration to enable open telemetry is better?
Sorry, I haven't brought my computer recently. I will solve this problem latter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org