You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/10 14:23:26 UTC
[GitHub] [zeppelin] dntjr8096 opened a new pull request, #4403: [ZEPPELIN-5762] Change default profile activation to build successfully
dntjr8096 opened a new pull request, #4403:
URL: https://github.com/apache/zeppelin/pull/4403
### What is this PR for?
When building from the source code, the default profile activation option of the zeppelin-server module is "using-source-tree", so I get the error as in the screenshot. So I changed the default profile activation option in the "zeppelin-server module" to hadoop2.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Documentation?
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5762
### How should this be tested?
I tested with Travis CI, which is set by default. And after modifying the source code, I tried to build again.
### Screenshots (if appropriate)
* ```./mvnw clean package -DskipTests ``` before modifying the profile with 'hadoop2'
* ```./mvnw clean package -DskipTests ``` after modifying the profile with 'hadoop2'
### Questions:
* Does the licenses files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop2 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#issuecomment-1179741691
It's better to update `.github/workflows/core.yml` to verify this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop2 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#issuecomment-1179769338
Instead of Hadoop 2, we should prefer Hadoop 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] dntjr8096 commented on pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop3 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
dntjr8096 commented on PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#issuecomment-1181822112
ok. I ran a git-rebase and added a 'default-build' workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop3 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
jongyoul commented on code in PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#discussion_r919600069
##########
.github/workflows/core.yml:
##########
@@ -448,3 +448,29 @@ jobs:
R -e "IRkernel::installspec()"
- name: run tests
run: ./mvnw verify -DskipRat -pl livy -am -B
+
+ default-build:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Tune Runner VM
+ uses: ./.github/actions/tune-runner-vm
+ - name: Set up JDK 8
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 8
+ - name: Cache local Maven repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository
+ !~/.m2/repository/org/apache/zeppelin/
+ ~/.spark-dist
+ ~/.cache
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-zeppelin-
+ - name: build without any profiles
+ run: ./mvnw clean package -DskipTests
Review Comment:
Please enter a new line at the end of the file :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop2 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#issuecomment-1179742276
> It's better to update .github/workflows/core.yml to verify this change.
Do you mean to add a new task to confirm the compilation itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop3 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
Reamer merged PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop3 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#issuecomment-1181797768
Please run a git-rebase to the current master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] dntjr8096 commented on a diff in pull request #4403: [ZEPPELIN-5762] Modify activeByDefault value of hadoop3 profile to true for successful build.
Posted by GitBox <gi...@apache.org>.
dntjr8096 commented on code in PR #4403:
URL: https://github.com/apache/zeppelin/pull/4403#discussion_r919633541
##########
.github/workflows/core.yml:
##########
@@ -448,3 +448,29 @@ jobs:
R -e "IRkernel::installspec()"
- name: run tests
run: ./mvnw verify -DskipRat -pl livy -am -B
+
+ default-build:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Tune Runner VM
+ uses: ./.github/actions/tune-runner-vm
+ - name: Set up JDK 8
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 8
+ - name: Cache local Maven repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository
+ !~/.m2/repository/org/apache/zeppelin/
+ ~/.spark-dist
+ ~/.cache
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-zeppelin-
+ - name: build without any profiles
+ run: ./mvnw clean package -DskipTests
Review Comment:
ok :) I'll be doing that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org