You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/30 11:57:36 UTC

[GitHub] [airflow] anitakar opened a new pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting

anitakar opened a new pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting
URL: https://github.com/apache/airflow/pull/7296
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373382747
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -128,3 +129,17 @@ def test_get_dag_runs_no_runs(self):
 
         self.assertIsInstance(data, list)
         self.assertEqual(len(data), 0)
+
+
+class TestDagRunsEndpointStoreDAGs(TestDagRunsEndpoint):
+
+    def setUp(self):
+        super().setUp()
+        app, _ = application.create_app(testing=True)
 
 Review comment:
   To generate identical tests, but in different configurations, it is worth using parameterized. I think that only one endpoint should be tested, so it won't be a big problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373085145
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -48,6 +48,8 @@ def tearDown(self):
         session.query(DagRun).delete()
         session.commit()
         session.close()
+        from airflow.configuration import conf as global_conf
+        global_conf.set('core', 'store_serialized_dags', 'False')
 
 Review comment:
   I think it's worth testing two cases - when store_serialized_dags = true and when store_serialized_dags = False

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r372987673
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   Funny, without it all tests fail.
   ![image](https://user-images.githubusercontent.com/4841572/73459243-ccd5ff80-4376-11ea-8055-5c542e48218c.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373378087
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -48,6 +48,8 @@ def tearDown(self):
         session.query(DagRun).delete()
         session.commit()
         session.close()
+        from airflow.configuration import conf as global_conf
+        global_conf.set('core', 'store_serialized_dags', 'False')
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r372933497
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   This probably point to the fact that i should have written a test or e2e test this case but what will happen if core.store_serialized_dags is not specified KeyError or will it coerce to false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373407644
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -41,6 +41,7 @@ def setUpClass(cls):
     def setUp(self):
         super().setUp()
         app, _ = application.create_app(testing=True)
+        app.config['STORE_SERIALIZED_DAGS'] = False
 
 Review comment:
   Ok, I have found it in another test: @conf_vars({('core', 'enable_xcom_pickling'): 'True'})

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581185529
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=h1) Report
   > Merging [#7296](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9d8d0755789d4aeadc5d3015f3cdde62901f85b8?src=pr&el=desc) will **increase** coverage by `53.14%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7296/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7296       +/-   ##
   ===========================================
   + Coverage   32.86%   86.01%   +53.14%     
   ===========================================
     Files         867      867               
     Lines       40560    40566        +6     
   ===========================================
   + Hits        13332    34893    +21561     
   + Misses      27228     5673    -21555
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==) | `98.03% <100%> (+18.44%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
   | [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <0%> (ø)` | :arrow_up: |
   | [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/version.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy92ZXJzaW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/contrib/hooks/jira\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2ppcmFfaG9vay5weQ==) | `0% <0%> (ø)` | :arrow_up: |
   | ... and [845 more](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=footer). Last update [9d8d075...e61891a](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373382336
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -41,6 +41,7 @@ def setUpClass(cls):
     def setUp(self):
         super().setUp()
         app, _ = application.create_app(testing=True)
+        app.config['STORE_SERIALIZED_DAGS'] = False
 
 Review comment:
   To generate identical tests, but in different configurations, it is worth using parameterized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373521290
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,12 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    from airflow.configuration import conf as global_conf
 
 Review comment:
   ```suggestion
       from airflow.configuration import conf
   ```
   
   Is what we do everywhere else in Airflow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r372987673
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   Funny, without it all tests fail.
   ![image](https://user-images.githubusercontent.com/4841572/73459243-ccd5ff80-4376-11ea-8055-5c542e48218c.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r372935140
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   core.store_serialized_dags always exists because it is defined in the default configuration. https://github.com/apache/airflow/blob/master/airflow/config_templates/default_airflow.cfg
   https://github.com/apache/airflow/blob/master/airflow/configuration.py#L174-L176

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581185529
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=h1) Report
   > Merging [#7296](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a2d6a2f85e07c38be479e91e4a27981f308f4711?src=pr&el=desc) will **increase** coverage by `0.72%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7296/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7296      +/-   ##
   ==========================================
   + Coverage   85.34%   86.07%   +0.72%     
   ==========================================
     Files         863      871       +8     
     Lines       40484    40573      +89     
   ==========================================
   + Hits        34552    34922     +370     
   + Misses       5932     5651     -281
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==) | `98.07% <100%> (+0.11%)` | :arrow_up: |
   | [...rflow/providers/apache/cassandra/sensors/record.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9zZW5zb3JzL3JlY29yZC5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [...irflow/providers/apache/cassandra/sensors/table.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9zZW5zb3JzL3RhYmxlLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/providers/papermill/operators/papermill.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcGFwZXJtaWxsL29wZXJhdG9ycy9wYXBlcm1pbGwucHk=) | `96% <0%> (-4%)` | :arrow_down: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (-0.63%)` | :arrow_down: |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.28% <0%> (-0.43%)` | :arrow_down: |
   | [airflow/sensors/bash.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2gucHk=) | `93.75% <0%> (-0.19%)` | :arrow_down: |
   | [...w/providers/amazon/aws/operators/sagemaker\_base.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvc2FnZW1ha2VyX2Jhc2UucHk=) | `91.48% <0%> (-0.18%)` | :arrow_down: |
   | [airflow/models/variable.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdmFyaWFibGUucHk=) | `93.33% <0%> (-0.09%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/operators/datasync.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvZGF0YXN5bmMucHk=) | `34.19% <0%> (-0.04%)` | :arrow_down: |
   | ... and [823 more](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=footer). Last update [a2d6a2f...4d0d6d7](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373047376
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   It was another conf. It was argument from POST body to DAG run.
   For:
   curl -X POST http://localhost:8080/api/experimental/dags/tutorial/dag_runs -H 'Cache-Control: no-cache' -H 'Content-Type: application/json' -d '{"conf":"{\"key\":\"value\"}"}'
   It would have been:
   {"key":"value"}
   Unit test fails. My end to end test fails.
   It is work in progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [WIP][AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [WIP][AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373076093
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   Ok, fixed, works in tests and e2e

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373382014
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -41,6 +41,7 @@ def setUpClass(cls):
     def setUp(self):
         super().setUp()
         app, _ = application.create_app(testing=True)
+        app.config['STORE_SERIALIZED_DAGS'] = False
 
 Review comment:
   Can you use conf_vars context manager/decorator here to avoid side-effect, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581136512
 
 
   Please rebase to latest master @anitakar   - we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373382014
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -41,6 +41,7 @@ def setUpClass(cls):
     def setUp(self):
         super().setUp()
         app, _ = application.create_app(testing=True)
+        app.config['STORE_SERIALIZED_DAGS'] = False
 
 Review comment:
   Can you use conf_vars context manager/decorator here to avoid side-effect?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373565889
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,12 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    from airflow.configuration import conf as global_conf
 
 Review comment:
   I understand. But I needed a different name because conf parameters is already passed to this method and it denotes conf for dag run (additional parameters)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r374052183
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -65,6 +68,13 @@ def test_get_dag_runs_success(self):
         self.assertEqual(data[0]['dag_id'], dag_id)
         self.assertEqual(data[0]['id'], dag_run.id)
 
+    @conf_vars({("core", "store_serialized_dags"): "True"})
+    def test_get_dag_runs_success_serialized_dags(self):
+        dagbag = DagBag(include_examples=True)
+        dag = dagbag.get_dag('example_bash_operator')
+        SerializedDagModel.write_dag(dag)
+        self.test_get_dag_runs_success()
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r374051934
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -128,3 +129,17 @@ def test_get_dag_runs_no_runs(self):
 
         self.assertIsInstance(data, list)
         self.assertEqual(len(data), 0)
+
+
+class TestDagRunsEndpointStoreDAGs(TestDagRunsEndpoint):
+
+    def setUp(self):
+        super().setUp()
+        app, _ = application.create_app(testing=True)
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581185529
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=h1) Report
   > Merging [#7296](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9d8d0755789d4aeadc5d3015f3cdde62901f85b8?src=pr&el=desc) will **increase** coverage by `53.14%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7296/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7296       +/-   ##
   ===========================================
   + Coverage   32.86%   86.01%   +53.14%     
   ===========================================
     Files         867      867               
     Lines       40560    40566        +6     
   ===========================================
   + Hits        13332    34893    +21561     
   + Misses      27228     5673    -21555
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==) | `98.03% <100%> (+18.44%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
   | [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <0%> (ø)` | :arrow_up: |
   | [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/version.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy92ZXJzaW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/contrib/hooks/jira\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2ppcmFfaG9vay5weQ==) | `0% <0%> (ø)` | :arrow_up: |
   | ... and [845 more](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=footer). Last update [9d8d075...e61891a](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373084022
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -48,6 +48,8 @@ def tearDown(self):
         session.query(DagRun).delete()
         session.commit()
         session.close()
+        from airflow.configuration import conf as global_conf
+        global_conf.set('core', 'store_serialized_dags', 'False')
 
 Review comment:
   Can you use conf_vars to avoid side-effect? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r374004911
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -65,6 +68,13 @@ def test_get_dag_runs_success(self):
         self.assertEqual(data[0]['dag_id'], dag_id)
         self.assertEqual(data[0]['id'], dag_run.id)
 
+    @conf_vars({("core", "store_serialized_dags"): "True"})
+    def test_get_dag_runs_success_serialized_dags(self):
+        dagbag = DagBag(include_examples=True)
+        dag = dagbag.get_dag('example_bash_operator')
+        SerializedDagModel.write_dag(dag)
+        self.test_get_dag_runs_success()
 
 Review comment:
   Can you extract the common part to the new method and call from two test methods?  This will make it easier to understand because tests should not depend on other tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581185529
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=h1) Report
   > Merging [#7296](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9d8d0755789d4aeadc5d3015f3cdde62901f85b8?src=pr&el=desc) will **increase** coverage by `52.38%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7296/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7296       +/-   ##
   ===========================================
   + Coverage   32.86%   85.25%   +52.38%     
   ===========================================
     Files         867      871        +4     
     Lines       40560    40572       +12     
   ===========================================
   + Hits        13332    34591    +21259     
   + Misses      27228     5981    -21247
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `100% <ø> (+100%)` | :arrow_up: |
   | [...rflow/contrib/hooks/gcp\_video\_intelligence\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF92aWRlb19pbnRlbGxpZ2VuY2VfaG9vay5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
   | [...irflow/example\_dags/example\_kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9rdWJlcm5ldGVzX2V4ZWN1dG9yLnB5) | `85% <ø> (ø)` | :arrow_up: |
   | [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <ø> (ø)` | :arrow_up: |
   | [airflow/contrib/utils/weekday.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL3dlZWtkYXkucHk=) | `100% <ø> (+25%)` | :arrow_up: |
   | [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/hooks/qubole\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3F1Ym9sZV9ob29rLnB5) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/sensors/qubole\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcXVib2xlX3NlbnNvci5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/utils/gcp\_field\_sanitizer.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL2djcF9maWVsZF9zYW5pdGl6ZXIucHk=) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [1076 more](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=footer). Last update [9d8d075...74547d5](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581185529
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=h1) Report
   > Merging [#7296](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9d8d0755789d4aeadc5d3015f3cdde62901f85b8?src=pr&el=desc) will **increase** coverage by `52.38%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7296/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7296       +/-   ##
   ===========================================
   + Coverage   32.86%   85.25%   +52.38%     
   ===========================================
     Files         867      871        +4     
     Lines       40560    40572       +12     
   ===========================================
   + Hits        13332    34591    +21259     
   + Misses      27228     5981    -21247
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `100% <ø> (+100%)` | :arrow_up: |
   | [...rflow/contrib/hooks/gcp\_video\_intelligence\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF92aWRlb19pbnRlbGxpZ2VuY2VfaG9vay5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
   | [...irflow/example\_dags/example\_kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9rdWJlcm5ldGVzX2V4ZWN1dG9yLnB5) | `85% <ø> (ø)` | :arrow_up: |
   | [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <ø> (ø)` | :arrow_up: |
   | [airflow/contrib/utils/weekday.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL3dlZWtkYXkucHk=) | `100% <ø> (+25%)` | :arrow_up: |
   | [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/hooks/qubole\_hook.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3F1Ym9sZV9ob29rLnB5) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/sensors/qubole\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcXVib2xlX3NlbnNvci5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
   | [airflow/contrib/utils/gcp\_field\_sanitizer.py](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL2djcF9maWVsZF9zYW5pdGl6ZXIucHk=) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [1076 more](https://codecov.io/gh/apache/airflow/pull/7296/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=footer). Last update [9d8d075...74547d5](https://codecov.io/gh/apache/airflow/pull/7296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#issuecomment-581426248
 
 
   Awesome work, congrats on your first merged pull request!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r372932576
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   This should never throw an exception as the config is in the default_airflow.cfg

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373403153
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -41,6 +41,7 @@ def setUpClass(cls):
     def setUp(self):
         super().setUp()
         app, _ = application.create_app(testing=True)
+        app.config['STORE_SERIALIZED_DAGS'] = False
 
 Review comment:
   Could you give me an example of using "conf vars"? Do you mean AIRFLOW__CONFIG__STORE_SERIALIZED_DAGS global env variable.
   Sorry that I did not ask that earlier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services