You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/19 13:07:03 UTC

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc

Anonymitaet commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r924477597


##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
 `numIoThreads`| int| The number of threads used for handling connections to brokers | 1 
 `numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1 
 `useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false

Review Comment:
   what does `Deprecated` mean? `enableTls` is deprecated or something else?



##########
site2/website/versioned_docs/version-2.1.0-incubating/client-libraries-java.md:
##########
@@ -475,7 +475,7 @@ Pulsar currently supports two authentication schemes: [TLS](security-tls-authent
 
 ### TLS Authentication
 
-To use [TLS](security-tls-authentication), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.

Review Comment:
   @momo-jun FYI: here is a missing occurrence (the `.md` issue)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org