You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:34:14 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request, #5367: Docs: Add docs for using metadata_logs metadata table
singhpk234 opened a new pull request, #5367:
URL: https://github.com/apache/iceberg/pull/5367
### About the change
Adds the metadata_logs introduced via https://github.com/apache/iceberg/pull/5063 in the docs
cc @samredai, @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5367: Docs: Add docs for using metadata_logs metadata table
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#discussion_r931773913
##########
docs/spark-queries.md:
##########
@@ -227,6 +227,20 @@ SELECT * FROM prod.db.table.history
**This shows a commit that was rolled back.** The example has two snapshots with the same parent, and one is *not* an ancestor of the current table state.
{{< /hint >}}
+### Metadata Logs
+
+To show table metadata logs:
+
+```sql
+SELECT * from prod.db.table.metadata_logs
Review Comment:
sure, should i then rename it to metadata_log_entries ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on pull request #5367: [Core | Docs]: [FOLLOWUP] Add metadata_log_entries metadata table
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#issuecomment-1203731009
Thanks for the review @szehon-ho, @rdblue !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #5367: [Core | Docs]: [FOLLOWUP] Add metadata_log_entries metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#issuecomment-1201514298
Lets give a day or two for other comment, will merge the name change and doc if there is none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5367: Docs: Add docs for using metadata_logs metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#discussion_r931547169
##########
docs/spark-queries.md:
##########
@@ -227,6 +227,20 @@ SELECT * FROM prod.db.table.history
**This shows a commit that was rolled back.** The example has two snapshots with the same parent, and one is *not* an ancestor of the current table state.
{{< /hint >}}
+### Metadata Logs
+
+To show table metadata logs:
+
+```sql
+SELECT * from prod.db.table.metadata_logs
Review Comment:
Can we rename this metadata table? The name `metadata_logs` doesn't make sense to me since there is just the one log. The rows of the table are log entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5367: Docs: Add docs for using metadata_logs metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on code in PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#discussion_r931263635
##########
docs/spark-queries.md:
##########
@@ -227,6 +227,20 @@ SELECT * FROM prod.db.table.history
**This shows a commit that was rolled back.** The example has two snapshots with the same parent, and one is *not* an ancestor of the current table state.
{{< /hint >}}
+### Metadata Logs
+
+To show table metadata logs :
Review Comment:
Nit, extra space before ':'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5367: Docs: Add docs for using metadata_logs metadata table
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#discussion_r931794935
##########
docs/spark-queries.md:
##########
@@ -227,6 +227,20 @@ SELECT * FROM prod.db.table.history
**This shows a commit that was rolled back.** The example has two snapshots with the same parent, and one is *not* an ancestor of the current table state.
{{< /hint >}}
+### Metadata Logs
+
+To show table metadata logs:
+
+```sql
+SELECT * from prod.db.table.metadata_logs
+```
+
+| timestamp_millis | file | latest_snapshot_id | latest_schema_id | latest_sequence_number |
+| -- | -- | -- | -- | -- |
+| 1658211678838 | s3://.../table/metadata/00000-9441e604-b3c2-498a-a45a-6320e8ab9006.metadata.json | null | null | null |
Review Comment:
makes sense, done !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #5367: [Core | Docs]: [FOLLOWUP] Add metadata_log_entries metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#issuecomment-1203045400
Merged , thanks @singhpk234 , we can follow up if there are more concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho merged pull request #5367: [Core | Docs]: [FOLLOWUP] Add metadata_log_entries metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho merged PR #5367:
URL: https://github.com/apache/iceberg/pull/5367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5367: Docs: Add docs for using metadata_logs metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5367:
URL: https://github.com/apache/iceberg/pull/5367#discussion_r931547434
##########
docs/spark-queries.md:
##########
@@ -227,6 +227,20 @@ SELECT * FROM prod.db.table.history
**This shows a commit that was rolled back.** The example has two snapshots with the same parent, and one is *not* an ancestor of the current table state.
{{< /hint >}}
+### Metadata Logs
+
+To show table metadata logs:
+
+```sql
+SELECT * from prod.db.table.metadata_logs
+```
+
+| timestamp_millis | file | latest_snapshot_id | latest_schema_id | latest_sequence_number |
+| -- | -- | -- | -- | -- |
+| 1658211678838 | s3://.../table/metadata/00000-9441e604-b3c2-498a-a45a-6320e8ab9006.metadata.json | null | null | null |
Review Comment:
I think we should convert this to a timestamp rather than displaying millis. That's what we do in other tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org