You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Jeff Hagelberg <jn...@us.ibm.com> on 2017/01/12 19:21:48 UTC
Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache
lookups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/
-----------------------------------------------------------
(Updated Jan. 12, 2017, 7:21 p.m.)
Review request for atlas, David Kantor and Neeru Gupta.
Bugs: ATLAS-1386
https://issues.apache.org/jira/browse/ATLAS-1386
Repository: atlas
Description
-------
When using the GraphBackedTypeStore, many unnecessary gremlin queries are executed as part of DSL query translated that are for things that cannot possibly be types, for example field names and aliases. These changes eliminate unnecessary queries and consolidate the type lookup for trait and class types where it makes sense.
Diffs
-----
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f947e49f205b3d48c7387ee4df39938deff
repository/src/main/scala/org/apache/atlas/query/Expressions.scala ce21a597e79b684eaadc54f208f4a540d402f1b9
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9
repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala ee95a20a0bdd447d907b21a5d5a0642f4142bade
repository/src/main/scala/org/apache/atlas/query/Resolver.scala 0957c57156381bfae82409a3c88083f564d790e8
repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala dfa7093bec25e8954634af2a3f55f357eb7d46a1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 1217e4af1c8bd63b191025ab9098b16ec0867a4c
repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 1358159d9cdc6f36f3a34d7946707d329b10f9d3
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java dcb126454b9efc0b50f6835e6dd1371f3e16d359
Diff: https://reviews.apache.org/r/55436/diff/
Testing
-------
All Atlas tests run, no regressions found. There were some tests that failed both with and without these changes.
Thanks,
Jeff Hagelberg
Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache
lookups
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/#review162047
-----------------------------------------------------------
Ship it!
Thanks for adding the appropriate tests
- Vimal Sharma
On Jan. 12, 2017, 7:21 p.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55436/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 7:21 p.m.)
>
>
> Review request for atlas, David Kantor and Neeru Gupta.
>
>
> Bugs: ATLAS-1386
> https://issues.apache.org/jira/browse/ATLAS-1386
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When using the GraphBackedTypeStore, many unnecessary gremlin queries are executed as part of DSL query translated that are for things that cannot possibly be types, for example field names and aliases. These changes eliminate unnecessary queries and consolidate the type lookup for trait and class types where it makes sense.
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f947e49f205b3d48c7387ee4df39938deff
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala ce21a597e79b684eaadc54f208f4a540d402f1b9
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9
> repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala ee95a20a0bdd447d907b21a5d5a0642f4142bade
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala 0957c57156381bfae82409a3c88083f564d790e8
> repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala dfa7093bec25e8954634af2a3f55f357eb7d46a1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 1217e4af1c8bd63b191025ab9098b16ec0867a4c
> repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 1358159d9cdc6f36f3a34d7946707d329b10f9d3
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java dcb126454b9efc0b50f6835e6dd1371f3e16d359
>
> Diff: https://reviews.apache.org/r/55436/diff/
>
>
> Testing
> -------
>
> All Atlas tests run, no regressions found. There were some tests that failed both with and without these changes.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache
lookups
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/#review161520
-----------------------------------------------------------
Ship it!
Ship It!
- David Kantor
On Jan. 12, 2017, 7:21 p.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55436/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 7:21 p.m.)
>
>
> Review request for atlas, David Kantor and Neeru Gupta.
>
>
> Bugs: ATLAS-1386
> https://issues.apache.org/jira/browse/ATLAS-1386
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When using the GraphBackedTypeStore, many unnecessary gremlin queries are executed as part of DSL query translated that are for things that cannot possibly be types, for example field names and aliases. These changes eliminate unnecessary queries and consolidate the type lookup for trait and class types where it makes sense.
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f947e49f205b3d48c7387ee4df39938deff
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala ce21a597e79b684eaadc54f208f4a540d402f1b9
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9
> repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala ee95a20a0bdd447d907b21a5d5a0642f4142bade
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala 0957c57156381bfae82409a3c88083f564d790e8
> repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala dfa7093bec25e8954634af2a3f55f357eb7d46a1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 1217e4af1c8bd63b191025ab9098b16ec0867a4c
> repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 1358159d9cdc6f36f3a34d7946707d329b10f9d3
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java dcb126454b9efc0b50f6835e6dd1371f3e16d359
>
> Diff: https://reviews.apache.org/r/55436/diff/
>
>
> Testing
> -------
>
> All Atlas tests run, no regressions found. There were some tests that failed both with and without these changes.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache
lookups
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 6:11 p.m.)
Review request for atlas, David Kantor and Neeru Gupta.
Changes
-------
Rebased changes.
Bugs: ATLAS-1386
https://issues.apache.org/jira/browse/ATLAS-1386
Repository: atlas
Description
-------
When using the GraphBackedTypeStore, many unnecessary gremlin queries are executed as part of DSL query translated that are for things that cannot possibly be types, for example field names and aliases. These changes eliminate unnecessary queries and consolidate the type lookup for trait and class types where it makes sense.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6770c41d254de13e66eb80d8927f73965fa644a2
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java c79a55daf9f33ea25f9ca99ae77bf728175b3d82
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f947e49f205b3d48c7387ee4df39938deff
repository/src/main/scala/org/apache/atlas/query/Expressions.scala ce21a597e79b684eaadc54f208f4a540d402f1b9
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9
repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala ee95a20a0bdd447d907b21a5d5a0642f4142bade
repository/src/main/scala/org/apache/atlas/query/Resolver.scala 0957c57156381bfae82409a3c88083f564d790e8
repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala dfa7093bec25e8954634af2a3f55f357eb7d46a1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 1217e4af1c8bd63b191025ab9098b16ec0867a4c
repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 1358159d9cdc6f36f3a34d7946707d329b10f9d3
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java dcb126454b9efc0b50f6835e6dd1371f3e16d359
Diff: https://reviews.apache.org/r/55436/diff/
Testing
-------
All Atlas tests run, no regressions found. There were some tests that failed both with and without these changes.
Thanks,
Jeff Hagelberg
Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache
lookups
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/#review162264
-----------------------------------------------------------
Ship it!
Ship It!
- Vimal Sharma
On Jan. 18, 2017, 1 p.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55436/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 1 p.m.)
>
>
> Review request for atlas, David Kantor and Neeru Gupta.
>
>
> Bugs: ATLAS-1386
> https://issues.apache.org/jira/browse/ATLAS-1386
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When using the GraphBackedTypeStore, many unnecessary gremlin queries are executed as part of DSL query translated that are for things that cannot possibly be types, for example field names and aliases. These changes eliminate unnecessary queries and consolidate the type lookup for trait and class types where it makes sense.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6770c41d254de13e66eb80d8927f73965fa644a2
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 9f3b90e6c82a8a4f7489467fedc3f7fb0515db2b
> repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f947e49f205b3d48c7387ee4df39938deff
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala ce21a597e79b684eaadc54f208f4a540d402f1b9
> repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9
> repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala ee95a20a0bdd447d907b21a5d5a0642f4142bade
> repository/src/main/scala/org/apache/atlas/query/Resolver.scala 0957c57156381bfae82409a3c88083f564d790e8
> repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala dfa7093bec25e8954634af2a3f55f357eb7d46a1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 1217e4af1c8bd63b191025ab9098b16ec0867a4c
> repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 1358159d9cdc6f36f3a34d7946707d329b10f9d3
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java dcb126454b9efc0b50f6835e6dd1371f3e16d359
>
> Diff: https://reviews.apache.org/r/55436/diff/
>
>
> Testing
> -------
>
> All Atlas tests run, no regressions found. There were some tests that failed both with and without these changes.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache
lookups
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 1 p.m.)
Review request for atlas, David Kantor and Neeru Gupta.
Changes
-------
Updated error messages.
Bugs: ATLAS-1386
https://issues.apache.org/jira/browse/ATLAS-1386
Repository: atlas
Description
-------
When using the GraphBackedTypeStore, many unnecessary gremlin queries are executed as part of DSL query translated that are for things that cannot possibly be types, for example field names and aliases. These changes eliminate unnecessary queries and consolidate the type lookup for trait and class types where it makes sense.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6770c41d254de13e66eb80d8927f73965fa644a2
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 9f3b90e6c82a8a4f7489467fedc3f7fb0515db2b
repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 569d3f947e49f205b3d48c7387ee4df39938deff
repository/src/main/scala/org/apache/atlas/query/Expressions.scala ce21a597e79b684eaadc54f208f4a540d402f1b9
repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9
repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala ee95a20a0bdd447d907b21a5d5a0642f4142bade
repository/src/main/scala/org/apache/atlas/query/Resolver.scala 0957c57156381bfae82409a3c88083f564d790e8
repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala dfa7093bec25e8954634af2a3f55f357eb7d46a1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 1217e4af1c8bd63b191025ab9098b16ec0867a4c
repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 1358159d9cdc6f36f3a34d7946707d329b10f9d3
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java dcb126454b9efc0b50f6835e6dd1371f3e16d359
Diff: https://reviews.apache.org/r/55436/diff/
Testing
-------
All Atlas tests run, no regressions found. There were some tests that failed both with and without these changes.
Thanks,
Jeff Hagelberg