You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2026/04/08 10:12:30 UTC
[PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
aleksraiden opened a new pull request, #3431:
URL: https://github.com/apache/kvrocks/pull/3431
Bump rocksdb to v11.0.4 (see: https://github.com/facebook/rocksdb/releases/tag/v11.0.4)
This is a first public release at 11.х line.
**Key changes**:
- Add a new table option separate_key_value_in_data_block. When set to true keys and values will be stored separately in the data block, which can result in higher cpu cache hit rate and better compression. Works best with data blocks with sufficient restart intervals and large values. Previous versions of RocksDB will reject files written using this option
- Change the default value of CompactionOptionsUniversal::reduce_file_locking from false to true to improve write stall and reduce read regression
- Added new virtual methods AbortAllCompactions() and ResumeAllCompactions() to the DB class
- Added support for storing wide-column entity column values in blob files
- Added CompactionOptionsFIFO::max_data_files_size to support FIFO compaction trimming based on combined SST and blob file sizes
- Include interpolation search as an alternative to binary search, which typically performs better when keys are uniformly distributed. This is exposed as a new table option index_block_search_type. The default is binary_search.
- Remove deprecated options and clean-up codebase
- Bug fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on PR #3431:
URL: https://github.com/apache/kvrocks/pull/3431#issuecomment-4208661237
> Remove deprecated raw DB* variants of DB::Open and related functions. Some other minor public APIs were updated as a result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #3431:
URL: https://github.com/apache/kvrocks/pull/3431#issuecomment-4362981225
refer to #3468.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on PR #3431:
URL: https://github.com/apache/kvrocks/pull/3431#issuecomment-4208226370
I believe the public API was changed (breaking change) in version 11 (that's why it's incremented from 10 to 11):
```
/Users/runner/work/kvrocks/kvrocks/src/common/db_util.h:63:10: error: no matching function for call to 'OpenForReadOnly'
return rocksdb::DB::OpenForReadOnly(db_options, dbname, column_families, handles, dbptr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:186:17: note: candidate function not viable: no known conversion from 'rocksdb::DB **' to 'std::unique_ptr<DB> *' for 5th argument
static Status OpenForReadOnly(
^
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:175:17: note: candidate function not viable: requires at most 4 arguments, but 5 were provided
static Status OpenForReadOnly(const Options& options, const std::string& name,
^
In file included from /Users/runner/work/kvrocks/kvrocks/src/cluster/slot_migrate.cc:26:
/Users/runner/work/kvrocks/kvrocks/src/common/db_util.h:70:10: error: no matching function for call to 'OpenAsSecondary'
return rocksdb::DB::OpenAsSecondary(db_options, dbname, secondary_path, column_families, handles, dbptr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:256:17: note: candidate function not viable: no known conversion from 'rocksdb::DB **' to 'std::unique_ptr<DB> *' for 6th argument
static Status OpenAsSecondary(
^
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:221:17: note: candidate function not viable: requires 4 arguments, but 6 were provided
static Status OpenAsSecondary(const Options& options, const std::string& name,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #3431:
URL: https://github.com/apache/kvrocks/pull/3431#issuecomment-4245202605
@copilot Could you fix the build issue introduced by the new rocksdb version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed pull request #3431: chore(deps): bump rocksdb to v11.0.4
URL: https://github.com/apache/kvrocks/pull/3431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #3431:
URL: https://github.com/apache/kvrocks/pull/3431#issuecomment-4206909411
As I see, need a code patch to use this release:
/home/runner/work/kvrocks/kvrocks/src/common/db_util.h:78:7: error: address of overloaded function 'Open' cannot be static_cast to type 'rocksdb::Status (*)(const rocksdb::Options &, const std::string &, rocksdb::DB **)' (aka 'rocksdb::Status (*)(const rocksdb::Options &, const basic_string<char> &, rocksdb::DB **)') [clang-diagnostic-error]
78 | static_cast<rocksdb::Status (*)(const rocksdb::Options&, const std::string&, rocksdb::DB**)>(rocksdb::DB::Open),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): bump rocksdb to v11.0.4 [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #3431:
URL: https://github.com/apache/kvrocks/pull/3431#issuecomment-4245230369
Hmm the ASF org doesn't enable copilot agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org