You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2025/05/08 22:36:47 UTC
[PR] [sonataflow-images] Fix #3124 - Add support to Quarkus Registry and cache it for offline use [incubator-kie-tools]
ricardozanini opened a new pull request, #3127:
URL: https://github.com/apache/incubator-kie-tools/pull/3127
Fixes #3124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-images] Fix #3124 - Add support to Quarkus Registry and cache it for offline use [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #3127:
URL: https://github.com/apache/incubator-kie-tools/pull/3127#issuecomment-2876939486
> I am misunderstanding?
@wmedvede we used to **delete** the registry cache from .m2, this PR now keeps it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-images] Fix #3124 - Add support to Quarkus Registry and cache it for offline use [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3127:
URL: https://github.com/apache/incubator-kie-tools/pull/3127#discussion_r2085135939
##########
packages/sonataflow-devmode-image/resources/modules/sonataflow/devmode/build-config/module.yaml:
##########
@@ -26,7 +26,6 @@ envs:
value: "false"
- name: QUARKUS_EXTENSIONS
# NOTE: If you change the QUARKUS_EXTENSIONS value remember to update the scripts/logic/build-quarkus-app.sh too!
Review Comment:
I'll remove this comment since it's invalid in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-images] Fix #3124 - Add support to Quarkus Registry and cache it for offline use [incubator-kie-tools]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on PR #3127:
URL: https://github.com/apache/incubator-kie-tools/pull/3127#issuecomment-2876982328
> > I am misunderstanding?
>
> @wmedvede we used to **delete** the registry cache from .m2, this PR now keeps it.
yeah, my fault! the line with the removal is now deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-images] Fix #3124 - Add support to Quarkus Registry and cache it for offline use [incubator-kie-tools]
Posted by "masayag (via GitHub)" <gi...@apache.org>.
masayag commented on code in PR #3127:
URL: https://github.com/apache/incubator-kie-tools/pull/3127#discussion_r2083565031
##########
packages/sonataflow-devmode-image/resources/modules/sonataflow/devmode/build-config/module.yaml:
##########
@@ -26,7 +26,6 @@ envs:
value: "false"
- name: QUARKUS_EXTENSIONS
# NOTE: If you change the QUARKUS_EXTENSIONS value remember to update the scripts/logic/build-quarkus-app.sh too!
Review Comment:
unrelated to this PR, but couldn't find this script in this project. is this comment still valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-images] Fix #3124 - Add support to Quarkus Registry and cache it for offline use [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #3127:
URL: https://github.com/apache/incubator-kie-tools/pull/3127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org