You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/01 05:01:37 UTC

[GitHub] [tvm] srkreddy1238 commented on pull request #11180: [OpenCL] Change of OpenCL profiling logic

srkreddy1238 commented on PR #11180:
URL: https://github.com/apache/tvm/pull/11180#issuecomment-1233742441

   @argrento 
   
   This PR causes CLML profiling failure. Reason explained here
   
   In general the workspaces can be accessed and shared via “device_api.opencl”. CLML integration shares the workspace created by default OpenCL and it has a reference to the command queue.
   
   Why do we enable profiler in compilation when we don't want to profile any thing ? 
   Or 
   Is there any case where we enable profiling some thing else but not OpenCL  / dynamically enable/disable profiling? In such cases we could think of having different compilation flag for OpenCL or environment varible to control at runtime launch.
   
   At any case dynamically recreating the queue will cause issues for other components.
   
   @masahi & @valmat07 comment pls.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org