You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "nateprewitt (via GitHub)" <gi...@apache.org> on 2026/02/16 18:00:38 UTC
[PR] GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls [arrow]
nateprewitt opened a new pull request, #49301:
URL: https://github.com/apache/arrow/pull/49301
### Rationale for this change
After discussion in #49169, this PR will add a unique identifier to the AzureFileSystem implementation to distinguish calls from the base Azure C++ SDK.
### What changes are included in this PR?
This PR adds `azpartner-arrow/{verion}` as the ApplicationId used by AzureFileSystem.
### Are these changes tested?
The change has been manually validated. I'm happy to add a test for its persistence, but I wasn't sure what level you'd like to see in Arrow. This is effectively just plumbing a string to the SDK. The ApplicationId functionality is validated in the SDK test suite.
### Are there any user-facing changes?
This shouldn't be user facing. Only a user-agent update for the underlying SDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49301:
URL: https://github.com/apache/arrow/pull/49301#issuecomment-3909830032
:warning: GitHub issue #49169 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49301:
URL: https://github.com/apache/arrow/pull/49301#discussion_r2814510185
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -386,9 +387,13 @@ Result<std::unique_ptr<Blobs::BlobServiceClient>> AzureOptions::MakeBlobServiceC
return Status::Invalid("AzureOptions::blob_storage_scheme must be http or https: ",
blob_storage_scheme);
}
+ Blobs::BlobClientOptions client_options;
+ client_options.Telemetry.ApplicationId =
+ "azpartner-arrow/" + GetBuildInfo().version_string;
Review Comment:
Could you create an internal function that returns this string and share it in 2 locations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls [arrow]
Posted by "nateprewitt (via GitHub)" <gi...@apache.org>.
nateprewitt commented on PR #49301:
URL: https://github.com/apache/arrow/pull/49301#issuecomment-3915881135
It looks like GitHub is having unreported auth issues in some of the actions. They made need a manual rerun once that's fixed.
> Error: fatal: could not read Username for 'https://github.com/': terminal prompts disabled
Error: fatal: expected flush after ref listing
> github.GithubException.BadCredentialsException: 401 {"message": "Bad credentials", "documentation_url": "https://docs.github.com/rest", "status": "401"}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49301:
URL: https://github.com/apache/arrow/pull/49301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org