You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/23 18:28:26 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #16051: [BEAM-13193] Support StandardProtocols.Enum.CONTROL_REQUEST_ELEMENTS_…

lukecwik commented on a change in pull request #16051:
URL: https://github.com/apache/beam/pull/16051#discussion_r755402988



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -464,6 +465,9 @@ public BundleFinalizer getBundleFinalizer() {
                 request.getInstructionId(),
                 bundleProcessor.getInboundEndpointApiServiceDescriptors(),
                 observer);
+            if (request.getProcessBundle().hasElements()) {
+              observer.accept(request.getProcessBundle().getElements());

Review comment:
       Wasn't the contract that all the data had to come from the ProcessBundleRequest and if not that would be an error or did we swap back to treating it like a prefix (you have implemented the latter)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org