You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/11 12:00:22 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7144: ARROW-4018: [C++] Fix RLE tests' failures on big-endian platforms

pitrou commented on a change in pull request #7144:
URL: https://github.com/apache/arrow/pull/7144#discussion_r422988328



##########
File path: cpp/src/arrow/util/bpacking_default.h
##########
@@ -31,6 +31,7 @@ namespace internal {
 
 inline const uint32_t* unpack1_32(const uint32_t* in, uint32_t* out) {
   uint32_t inl = util::SafeLoad(in);
+  inl = arrow::BitUtil::ToLittleEndian(inl);

Review comment:
       Shouldn't this be `FromLittleEndian`? (it will produce the same code, but it seems logically more accurate)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org