[jira] [Commented] (HBASE-14342) Recursive call in RegionMergeTransactionImpl.getJournal()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724475#comment-14724475 ] 

Hadoop QA commented on HBASE-14342:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12753383/HBASE-14342-branch-1.patch
  against branch-1 branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
  ATTACHMENT ID: 12753383

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.util.TestProcessBasedCluster

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15365//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15365//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15365//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15365//console

This message is automatically generated.

> Recursive call in RegionMergeTransactionImpl.getJournal()
> ---------------------------------------------------------
>
>                 Key: HBASE-14342
>                 URL: https://issues.apache.org/jira/browse/HBASE-14342
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 1.1.1
>            Reporter: Lars George
>            Assignee: Lars Francke
>              Labels: beginner
>             Fix For: 1.2.0, 1.1.2
>
>         Attachments: HBASE-14342-branch-1.patch, HBASE-14342-branch-1.patch
>
>
> HBASE-12975 in its branch-1 patch (https://issues.apache.org/jira/secure/attachment/12708578/HBASE-12975-branch-1.patch) introduced a recursive call for {{getJournal()}}. Needs to return just the {{journal}} variable like master patch does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)