You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/02/06 03:14:16 UTC
[kudu-CR] [docker] Add publish support to the build script
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12380
Change subject: [docker] Add publish support to the build script
......................................................................
[docker] Add publish support to the build script
This patch adds publish support to the docker build
script by tracking the tags through the build and
pushing them via docker push once all builds/tags
are complete.
Only release builds are permitted to be published.
Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
---
M docker/docker-build.sh
1 file changed, 35 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/12380/1
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Add publish support to the build script
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12380
to look at the new patch set (#2).
Change subject: [docker] Add publish support to the build script
......................................................................
[docker] Add publish support to the build script
This patch adds publish support to the docker build
script by tracking the tags through the build and
pushing them via docker push once all builds/tags
are complete.
Only release builds are permitted to be published.
Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
---
M docker/docker-build.sh
1 file changed, 35 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/12380/2
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add publish support to the build script
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12380 )
Change subject: [docker] Add publish support to the build script
......................................................................
[docker] Add publish support to the build script
This patch adds publish support to the docker build
script by tracking the tags through the build and
pushing them via docker push once all builds/tags
are complete.
Only release builds are permitted to be published.
Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Reviewed-on: http://gerrit.cloudera.org:8080/12380
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docker/docker-build.sh
1 file changed, 35 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add publish support to the build script
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12380 )
Change subject: [docker] Add publish support to the build script
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12380/2/docker/docker-build.sh
File docker/docker-build.sh:
http://gerrit.cloudera.org:8080/#/c/12380/2/docker/docker-build.sh@206
PS2, Line 206: # Add the latest version tags.
: if [[ "$TAG_LATEST" == "1" ]]; then
: LATEST_TAG=$(get_tag "$TARGET" "latest" "$OS_TAG")
: docker tag "$FULL_TAG" "$LATEST_TAG"
: TAGS+=("$LATEST_TAG")
:
: # Add the default OS tag.
: if [[ "$BASE_OS" == "$DEFAULT_OS" ]]; then
: LATEST_DEFAULT_OS_TAG=$(get_tag "$TARGET" "latest" "")
: docker tag "$FULL_TAG" "$LATEST_DEFAULT_OS_TAG"
: TAGS+=("$LATEST_DEFAULT_OS_TAG")
: fi
: fi
> As this becomes more integrated with our release process, will this get rid
Tags that replace an old tag are overwritten. So the latest version of any tag will always be the most recently built image. There won't be a "history" of latest tags.
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 04:52:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add publish support to the build script
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12380 )
Change subject: [docker] Add publish support to the build script
......................................................................
Patch Set 1:
I published a centos6 and xenial sample image to my personal repo to test this:
https://cloud.docker.com/repository/docker/granthenke/kudu
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 03:15:03 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Add publish support to the build script
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12380 )
Change subject: [docker] Add publish support to the build script
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 04:53:20 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Add publish support to the build script
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12380 )
Change subject: [docker] Add publish support to the build script
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12380/2/docker/docker-build.sh
File docker/docker-build.sh:
http://gerrit.cloudera.org:8080/#/c/12380/2/docker/docker-build.sh@206
PS2, Line 206: # Add the latest version tags.
: if [[ "$TAG_LATEST" == "1" ]]; then
: LATEST_TAG=$(get_tag "$TARGET" "latest" "$OS_TAG")
: docker tag "$FULL_TAG" "$LATEST_TAG"
: TAGS+=("$LATEST_TAG")
:
: # Add the default OS tag.
: if [[ "$BASE_OS" == "$DEFAULT_OS" ]]; then
: LATEST_DEFAULT_OS_TAG=$(get_tag "$TARGET" "latest" "")
: docker tag "$FULL_TAG" "$LATEST_DEFAULT_OS_TAG"
: TAGS+=("$LATEST_DEFAULT_OS_TAG")
: fi
: fi
As this becomes more integrated with our release process, will this get rid of old "latest" tags? Or will that need to be done manually?
--
To view, visit http://gerrit.cloudera.org:8080/12380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc018f89da0a44ad76fae772aaede8eb5263d5d
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 04:50:55 +0000
Gerrit-HasComments: Yes