You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Glen Mazza <gm...@talend.com> on 2011/09/29 23:39:54 UTC

JettyHTTPServerEngine changes (r1177165 - in /cxf/branches/2.4.x-fixes...)

Hi Willem:

On 09/29/2011 01:05 AM, ningjiang@apache.org wrote:
> Author: ningjiang
> Date: Thu Sep 29 05:05:18 2011
> New Revision: 1177165
>
> Propchange: cxf/branches/2.4.x-fixes/
> ------------------------------------------------------------------------------
> Binary property 'svnmerge-integrated' - no diff available.
>
> Modified: cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java
> URL: http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java?rev=1177165&r1=1177164&r2=1177165&view=diff
> ==============================================================================
> --- cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java (original)
> +++ cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java Thu Sep 29 05:05:18 2011
> @@ -95,6 +95,7 @@ public class JettyHTTPServerEngine
>       private Boolean isSessionSupport = false;
>       private Boolean isReuseAddress = true;
>       private Boolean continuationsEnabled = true;
> +    private int maxIdleTime = 200000;
>       private int servantCount;
>       private Server server;
>       private Connector connector;
> @@ -281,6 +282,14 @@ public class JettyHTTPServerEngine
>           isReuseAddress = reuse;
>       }
> +
> +    public void setMaxIdleTime(int maxIdel) {
> +        maxIdleTime = maxIdel;
> +    }

(int maxIdle)

>
>       /**
>
> Modified: cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java
> URL: http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java?rev=1177165&r1=1177164&r2=1177165&view=diff
> ==============================================================================
> --- cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java (original)
> +++ cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java Thu Sep 29 05:05:18 2011
> @@ -70,6 +70,11 @@ public class JettyHTTPServerEngineBeanDe
>           if (continuationsStr != null&&  continuationsStr.length()>  0) {
>               bean.addPropertyValue("continuationsEnabled", continuationsStr);
>           }
> +
> +        String maxIdleTimeStr = element.getAttribute("maxIdleTime");
> +        if (maxIdleTimeStr != null&&  !"".equals(maxIdleTimeStr.trim())) {
> +            bean.addPropertyValue("maxIdleTime", maxIdleTimeStr);
> +        }
>           ValueHolder busValue = ctx.getContainingBeanDefinition()
>               .getConstructorArgumentValues().getArgumentValue(0, Bus.class);
>           bean.addPropertyValue("bus", busValue.getValue());
>
>
> Modified: cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd
> URL: http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd?rev=1177165&r1=1177164&r2=1177165&view=diff
> ==============================================================================
> --- cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd (original)
> +++ cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd Thu Sep 29 05:05:18 2011
> @@ -144,9 +144,14 @@
>          <xs:attribute name="continuationsEnabled" type="ptp:ParameterizedBoolean">
>              <xs:annotation>
>                   <xs:documentation>Specifies if Jetty Continuations will be explicitly supported
> -                by Jetty destinations. Continuations will be checked if this attribute is set to true or                            omitted, ignored otherwise</xs:documentation>
> +                by Jetty destinations. Continuations will be checked if this attribute is set to true or omitted, ignored otherwise.</xs:documentation>
>                </xs:annotation>
>          </xs:attribute>
> +<xs:attribute name="maxIdleTime" type="ptp:ParameterizedInt">
> +<xs:annotation>
> +<xs:documentation>Set the maximum Idle time for a connection, the timer will be reset if there is any read and write option on the under layer stream.</xs:documentation>

I'm not sure what you mean here by "option" and "under layer 
(underlying?) stream"--although it could be my lack of knowledge on the 
topic.

Regards,
Glen




-- 
Glen Mazza
Talend - http://www.talend.com/products/tsf
Blog - http://www.jroller.com/gmazza
Twitter - glenmazza


Re: JettyHTTPServerEngine changes (r1177165 - in /cxf/branches/2.4.x-fixes...)

Posted by Willem Jiang <wi...@gmail.com>.
On Fri Sep 30 05:39:54 2011, Glen Mazza wrote:
> Hi Willem:
>
> On 09/29/2011 01:05 AM, ningjiang@apache.org wrote:
>> Author: ningjiang
>> Date: Thu Sep 29 05:05:18 2011
>> New Revision: 1177165
>>
>> Propchange: cxf/branches/2.4.x-fixes/
>> ------------------------------------------------------------------------------ 
>>
>> Binary property 'svnmerge-integrated' - no diff available.
>>
>> Modified: 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java?rev=1177165&r1=1177164&r2=1177165&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java 
>> (original)
>> +++ 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java 
>> Thu Sep 29 05:05:18 2011
>> @@ -95,6 +95,7 @@ public class JettyHTTPServerEngine
>> private Boolean isSessionSupport = false;
>> private Boolean isReuseAddress = true;
>> private Boolean continuationsEnabled = true;
>> + private int maxIdleTime = 200000;
>> private int servantCount;
>> private Server server;
>> private Connector connector;
>> @@ -281,6 +282,14 @@ public class JettyHTTPServerEngine
>> isReuseAddress = reuse;
>> }
>> +
>> + public void setMaxIdleTime(int maxIdel) {
>> + maxIdleTime = maxIdel;
>> + }
>
> (int maxIdle)
>
>>
>> /**
>>
>> Modified: 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java?rev=1177165&r1=1177164&r2=1177165&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java 
>> (original)
>> +++ 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/spring/JettyHTTPServerEngineBeanDefinitionParser.java 
>> Thu Sep 29 05:05:18 2011
>> @@ -70,6 +70,11 @@ public class JettyHTTPServerEngineBeanDe
>> if (continuationsStr != null&& continuationsStr.length()> 0) {
>> bean.addPropertyValue("continuationsEnabled", continuationsStr);
>> }
>> +
>> + String maxIdleTimeStr = element.getAttribute("maxIdleTime");
>> + if (maxIdleTimeStr != null&& !"".equals(maxIdleTimeStr.trim())) {
>> + bean.addPropertyValue("maxIdleTime", maxIdleTimeStr);
>> + }
>> ValueHolder busValue = ctx.getContainingBeanDefinition()
>> .getConstructorArgumentValues().getArgumentValue(0, Bus.class);
>> bean.addPropertyValue("bus", busValue.getValue());
>>
>>
>> Modified: 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd 
>>
>> URL: 
>> http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd?rev=1177165&r1=1177164&r2=1177165&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd 
>> (original)
>> +++ 
>> cxf/branches/2.4.x-fixes/rt/transports/http-jetty/src/main/resources/schemas/configuration/http-jetty.xsd 
>> Thu Sep 29 05:05:18 2011
>> @@ -144,9 +144,14 @@
>> <xs:attribute name="continuationsEnabled" 
>> type="ptp:ParameterizedBoolean">
>> <xs:annotation>
>> <xs:documentation>Specifies if Jetty Continuations will be explicitly 
>> supported
>> - by Jetty destinations. Continuations will be checked if this 
>> attribute is set to true or omitted, ignored 
>> otherwise</xs:documentation>
>> + by Jetty destinations. Continuations will be checked if this 
>> attribute is set to true or omitted, ignored 
>> otherwise.</xs:documentation>
>> </xs:annotation>
>> </xs:attribute>
>> +<xs:attribute name="maxIdleTime" type="ptp:ParameterizedInt">
>> +<xs:annotation>
>> +<xs:documentation>Set the maximum Idle time for a connection, the 
>> timer will be reset if there is any read and write option on the 
>> under layer stream.</xs:documentation>
>
> I'm not sure what you mean here by "option" and "under layer 
> (underlying?) stream"--although it could be my lack of knowledge on 
> the topic.
>
After read the sentence twice, I think the option should be action, 
which means if there is no any data is received or sent, the stream 
will be closed.

> Regards,
> Glen
>
>
>
>



-- 
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog:    http://willemjiang.blogspot.com (English)
         http://jnn.javaeye.com (Chinese)
Twitter: willemjiang 
Weibo: willemjiang