[GitHub] [geode-examples] davebarnes97 commented on issue #69: GEODE-5806: Adding example for durable messaging in client subscriptions

["davebarnes97 (GitHub)" <gi...@apache.org>]

> > "saved in queue" -> "save in a queue"
> This one is actually just right out of our manual so I think the same fix needs to go there.

Yes, thanks for the pointer.
 
> > "A simple cache listener is used to print output to terminal create events are received" -> "output to the terminal as create events are received"
> 
> Do you think it isn't worth mentioning that a cache listener is used to print to terminal? I suppose they can see that in the code, but technically cache listeners are a different topic and I didn't want users to be lost if they didn't know about cache listeners.

Not my intention - unclear comment on my part. I'm suggesting the following:
- Leave the 'cache listener' part in place
- Replace  "output to terminal create events are received" with "output to *the* terminal *as* create events are received"





[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org