You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Andrei Pozolotin (Created) (JIRA)" <ji...@apache.org> on 2011/11/30 00:57:40 UTC

[jira] [Created] (KARAF-1062) make config file parser smarter

make config file parser smarter
-------------------------------

                 Key: KARAF-1062
                 URL: https://issues.apache.org/jira/browse/KARAF-1062
             Project: Karaf
          Issue Type: Bug
          Components: karaf-config
            Reporter: Andrei Pozolotin


1) currently, the following config file works fine:

org.apache.karaf.features.cfg

#############################

#
# Comma separated list of features repositories to register by default
#
featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml

#
# Comma separated list of features to install at startup
#
featuresBoot=config,ssh,management,eventadmin,scala-library

#############################

2) but if I make it more readble:

#############################

#
# Comma separated list of features repositories to register by default
#
featuresRepositories= \
	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
	file:./etc/features-scala.xml, \

#
# Comma separated list of features to install at startup
#
featuresBoot= \
	config, \
	ssh, \
	management, \
	eventadmin, \
	scala-library, \

#############################

then karaf blows up with exception;

the following would help:

1) trim spaces
2) allow trailing commas
3) process variable substitutions


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KARAF-1062) make config file parser smarter

Posted by "Jean-Baptiste Onofré (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159812#comment-13159812 ] 

Jean-Baptiste Onofré commented on KARAF-1062:
---------------------------------------------

Hi Andrei,

I think that the issues are:
- don't start directly with \
- don't stop with ,\

For instance, something like:

featuresRepositories=mvn...,\
mvn...,\
mvn....

should workd.
                
> make config file parser smarter
> -------------------------------
>
>                 Key: KARAF-1062
>                 URL: https://issues.apache.org/jira/browse/KARAF-1062
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>            Reporter: Andrei Pozolotin
>
> 1) currently, the following config file works fine:
> org.apache.karaf.features.cfg
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot=config,ssh,management,eventadmin,scala-library
> #############################
> 2) but if I make it more readble:
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories= \
> 	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
> 	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
> 	file:./etc/features-scala.xml, \
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot= \
> 	config, \
> 	ssh, \
> 	management, \
> 	eventadmin, \
> 	scala-library, \
> #############################
> then karaf blows up with exception;
> the following would help:
> 1) trim spaces
> 2) allow trailing commas
> 3) process variable substitutions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Assigned] (KARAF-1062) make config file parser smarter

Posted by "Jean-Baptiste Onofré (Assigned JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofré reassigned KARAF-1062:
-------------------------------------------

    Assignee: Jean-Baptiste Onofré
    
> make config file parser smarter
> -------------------------------
>
>                 Key: KARAF-1062
>                 URL: https://issues.apache.org/jira/browse/KARAF-1062
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>            Reporter: Andrei Pozolotin
>            Assignee: Jean-Baptiste Onofré
>
> 1) currently, the following config file works fine:
> org.apache.karaf.features.cfg
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot=config,ssh,management,eventadmin,scala-library
> #############################
> 2) but if I make it more readble:
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories= \
> 	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
> 	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
> 	file:./etc/features-scala.xml, \
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot= \
> 	config, \
> 	ssh, \
> 	management, \
> 	eventadmin, \
> 	scala-library, \
> #############################
> then karaf blows up with exception;
> the following would help:
> 1) trim spaces
> 2) allow trailing commas
> 3) process variable substitutions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (KARAF-1062) make config file parser smarter

Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie goodyear resolved KARAF-1062.
-----------------------------------

    Resolution: Not A Problem

The issue no longer affects 2.2.x, 2.3.x, or 3.0.x lines. Removing from open issues list.
                
> make config file parser smarter
> -------------------------------
>
>                 Key: KARAF-1062
>                 URL: https://issues.apache.org/jira/browse/KARAF-1062
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>            Reporter: Andrei Pozolotin
>
> 1) currently, the following config file works fine:
> org.apache.karaf.features.cfg
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot=config,ssh,management,eventadmin,scala-library
> #############################
> 2) but if I make it more readble:
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories= \
> 	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
> 	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
> 	file:./etc/features-scala.xml, \
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot= \
> 	config, \
> 	ssh, \
> 	management, \
> 	eventadmin, \
> 	scala-library, \
> #############################
> then karaf blows up with exception;
> the following would help:
> 1) trim spaces
> 2) allow trailing commas
> 3) process variable substitutions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KARAF-1062) make config file parser smarter

Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432353#comment-13432353 ] 

Jamie goodyear commented on KARAF-1062:
---------------------------------------

We should probably close this issue as resolved.

Thank you for reviewing this jira Heath.
                
> make config file parser smarter
> -------------------------------
>
>                 Key: KARAF-1062
>                 URL: https://issues.apache.org/jira/browse/KARAF-1062
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>            Reporter: Andrei Pozolotin
>
> 1) currently, the following config file works fine:
> org.apache.karaf.features.cfg
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot=config,ssh,management,eventadmin,scala-library
> #############################
> 2) but if I make it more readble:
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories= \
> 	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
> 	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
> 	file:./etc/features-scala.xml, \
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot= \
> 	config, \
> 	ssh, \
> 	management, \
> 	eventadmin, \
> 	scala-library, \
> #############################
> then karaf blows up with exception;
> the following would help:
> 1) trim spaces
> 2) allow trailing commas
> 3) process variable substitutions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (KARAF-1062) make config file parser smarter

Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofré reassigned KARAF-1062:
-------------------------------------------

    Assignee:     (was: Jean-Baptiste Onofré)
    
> make config file parser smarter
> -------------------------------
>
>                 Key: KARAF-1062
>                 URL: https://issues.apache.org/jira/browse/KARAF-1062
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>            Reporter: Andrei Pozolotin
>
> 1) currently, the following config file works fine:
> org.apache.karaf.features.cfg
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot=config,ssh,management,eventadmin,scala-library
> #############################
> 2) but if I make it more readble:
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories= \
> 	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
> 	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
> 	file:./etc/features-scala.xml, \
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot= \
> 	config, \
> 	ssh, \
> 	management, \
> 	eventadmin, \
> 	scala-library, \
> #############################
> then karaf blows up with exception;
> the following would help:
> 1) trim spaces
> 2) allow trailing commas
> 3) process variable substitutions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1062) make config file parser smarter

Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431856#comment-13431856 ] 

Heath Kesler commented on KARAF-1062:
-------------------------------------

I noticed this is an older jira, but I can not recreate this in 2.2.8, 2.3 or 3.0.

I even tried it using the following:

don't start directly with \
don't stop with ,\

without error in all versions
                
> make config file parser smarter
> -------------------------------
>
>                 Key: KARAF-1062
>                 URL: https://issues.apache.org/jira/browse/KARAF-1062
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>            Reporter: Andrei Pozolotin
>
> 1) currently, the following config file works fine:
> org.apache.karaf.features.cfg
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories=mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features,mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features,file:./etc/features-scala.xml
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot=config,ssh,management,eventadmin,scala-library
> #############################
> 2) but if I make it more readble:
> #############################
> #
> # Comma separated list of features repositories to register by default
> #
> featuresRepositories= \
> 	mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features, \
> 	mvn:org.apache.karaf.assemblies.features/enterprise/2.2.4/xml/features, \
> 	file:./etc/features-scala.xml, \
> #
> # Comma separated list of features to install at startup
> #
> featuresBoot= \
> 	config, \
> 	ssh, \
> 	management, \
> 	eventadmin, \
> 	scala-library, \
> #############################
> then karaf blows up with exception;
> the following would help:
> 1) trim spaces
> 2) allow trailing commas
> 3) process variable substitutions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira