svn commit: r278710 - /myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlRendererUtils.java

[mm...@apache.org]

Author: mmarinschek
Date: Mon Sep  5 03:22:40 2005
New Revision: 278710

URL: http://svn.apache.org/viewcvs?rev=278710&view=rev
Log:
fixed bug MYFACES-505

Modified:
    myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlRendererUtils.java

Modified: myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlRendererUtils.java
URL: http://svn.apache.org/viewcvs/myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlRendererUtils.java?rev=278710&r1=278709&r2=278710&view=diff
==============================================================================
--- myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlRendererUtils.java (original)
+++ myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlRendererUtils.java Mon Sep  5 03:22:40 2005
@@ -831,42 +831,44 @@
         String functionName = getClearHiddenCommandFormParamsFunctionName(formName);
         writer.startElement(HTML.SCRIPT_ELEM, null);
         writer.writeAttribute(HTML.TYPE_ATTR, "text/javascript", null);
-        writer.write("\n<!--");
-        writer.write("\nfunction ");
-        writer.write(functionName);
-        writer.write("() {");
+        // Use writeComment instead of write with <!-- tag
+        StringBuffer script = new StringBuffer();
+        script.append("\nfunction ");
+        script.append(functionName);
+        script.append("() {");
         if (dummyFormParams != null) {
-            writer.write("\n  var f = document.forms['");
-            writer.write(formName);
-            writer.write("'];");
+            script.append("\n  var f = document.forms['");
+            script.append(formName);
+            script.append("'];");
             for (Iterator it = dummyFormParams.iterator(); it.hasNext();) {
-                writer.write("\n  f.elements['");
-                writer.write((String) it.next());
-                writer.write("'].value='';");
+                script.append("\n  f.elements['");
+                script.append((String) it.next());
+                script.append("'].value='';");
             }
         }
         // clear form target
-        writer.write("\n  f.target=");
+        script.append("\n  f.target=");
         if (formTarget == null || formTarget.length() == 0) {
             //Normally one would think that setting target to null has the
             //desired effect, but once again IE is different...
             //Setting target to null causes IE to open a new window!
-            writer.write("'';");
+            script.append("'';");
         } else {
-            writer.write("'");
-            writer.write(formTarget);
-            writer.write("';");
+            script.append("'");
+            script.append(formTarget);
+            script.append("';");
         }
-        writer.write("\n}");
+        script.append("\n}");
 
         //Just to be sure we call this clear method on each load.
         //Otherwise in the case, that someone submits a form by pressing Enter
         //within a text input, the hidden inputs won't be cleared!
-        writer.write("\n");
-        writer.write(functionName);
-        writer.write("();");
+        script.append("\n");
+        script.append(functionName);
+        script.append("();");
 
-        writer.write("\n//-->\n");
+        script.append("\n");
+        writer.writeComment(script);
         writer.endElement(HTML.SCRIPT_ELEM);
     }