[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10474: Optimize java doc in ShardingRule class

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #10474:
URL: https://github.com/apache/shardingsphere/pull/10474#discussion_r639451716



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -240,10 +240,10 @@ public TableRule getTableRule(final String logicTableName) {
     }
     
     /**
-     * Judge logic tables is all belong to binding encryptors.
+     * Judge whether all logic tables belongs to binding encryptors.

Review comment:
       @KSMASTERS What do you think of this? 
   
   ```java
   /**
    * Judge whether all logic tables are binding encryptors or not.
    * 
    * @param logicTableNames logic table names
    * @return whether all logic tables are binding encryptors or not
    */
   ```
   
   If you think it's good, please use similar expressions to modify the Java doc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org