[GitHub] [superset] michael-s-molina commented on pull request #22168: feat(native-filters): Adhoc dashboard native filters

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on PR #22168:
URL: https://github.com/apache/superset/pull/22168#issuecomment-1514655272

   Thank you for the PR @cccs-RyanK!
   
   How will this filter behave considering inter filter features such as `Values depend on other filters` and `Filter scopes`? Specially in the case where we have a SQL value and it's hard to determine the referenced column/dataset.
   
   Is the popup arrow pointing to the correct direction when the filter bar is horizontal? We need to consider the scenario where the filter is displayed in the bar in which case the arrow should point up and the case where the filter is displayed in the dropdown in which case the arrow should point to the right.
   
   I agree with @yousoph's points.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org