You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 09:41:12 UTC

[GitHub] [airflow] kazanzhy commented on a change in pull request #20246: Fix MyPy Errors for HTTP provider.

kazanzhy commented on a change in pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#discussion_r767555129



##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -186,8 +186,8 @@ def run_and_check(
 
         # Send the request.
         send_kwargs = {
-            "timeout": extra_options.get("timeout"),
             "allow_redirects": extra_options.get("allow_redirects", True),
+            "timeout": extra_options.get("timeout"),

Review comment:
       I get the error
   ```
   Argument 2 to "send" of "Session" has incompatible type "**Dict[str, Optional[Any]]"; expected "bool"
   ```
   And these parameters switch helped avoid the error. Very strange




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org