[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #5966: arch:tcbinfo: update tcbinfo as xcpcontext update

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-nuttx/pull/5966#discussion_r841114513



##########
File path: arch/arm/src/armv7-m/arm_tcbinfo.c
##########
@@ -112,6 +112,8 @@ const struct tcbinfo_s g_tcbinfo =
   TCB_STATE_OFF,
   TCB_PRI_OFF,
   TCB_NAME_OFF,
+  TCB_REGS_OFF,
+  17,

Review comment:
       Don't we have a macro for thus value?  
   Also, I see that the `tcbinfo_s` struct has now another member, given the initialization way, is `XCPTCONTEXT_REGS` in the right position here?

##########
File path: include/nuttx/sched.h
##########
@@ -771,14 +772,16 @@ begin_packed_struct struct tcbinfo_s
   uint16_t state_off;                    /* Offset of tcb.task_state        */
   uint16_t pri_off;                      /* Offset of tcb.sched_priority    */
   uint16_t name_off;                     /* Offset of tcb.name              */
-  uint16_t reg_num;                      /* Num of regs in tcbinfo.reg_offs */
+  uint16_t regs_off;                     /* Offset of tcb.regs              */

Review comment:
       Can you please update xtensa_tcbinfo.c too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org