You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/15 17:20:54 UTC
[GitHub] [nifi-registry] mtien-apache opened a new pull request #318: NIFIREG-447 - Upgrade direct dependencies.
mtien-apache opened a new pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318
Thank you for submitting a contribution to Apache NiFi Registry.
Please provide a short description of the PR here:
#### Description of PR
_Upgraded direct dependencies. Tested by running a secure instance, creating buckets, and commit version control changes connected to a NiFi instance._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFIREG-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi-registry` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-registry-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-registry-assembly`?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] mtien-apache commented on a change in pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on a change in pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318#discussion_r596180552
##########
File path: pom.xml
##########
@@ -92,11 +92,12 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<inceptionYear>2017</inceptionYear>
<org.slf4j.version>1.7.30</org.slf4j.version>
- <jetty.version>9.4.19.v20190610</jetty.version>
+ <jetty.version>9.4.38.v20210224</jetty.version>
<jax.rs.api.version>2.1</jax.rs.api.version>
<jersey.server.version>2.29.1</jersey.server.version>
<jersey.client.version>2.28</jersey.client.version>
<jackson.version>2.10.3</jackson.version>
+ <jackson-databind.version>2.9.10.8</jackson-databind.version>
Review comment:
@exceptionfactory @bbende Agreed both `jackson-core` and `jackson-databind` can now be on the same minor version. Reverted back to use one `jackson.version` and bumped the version. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] exceptionfactory commented on pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318#issuecomment-801300061
+1 Merged! Thanks @mtien-apache!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] bbende commented on a change in pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318#discussion_r596090661
##########
File path: pom.xml
##########
@@ -92,11 +92,12 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<inceptionYear>2017</inceptionYear>
<org.slf4j.version>1.7.30</org.slf4j.version>
- <jetty.version>9.4.19.v20190610</jetty.version>
+ <jetty.version>9.4.38.v20210224</jetty.version>
<jax.rs.api.version>2.1</jax.rs.api.version>
<jersey.server.version>2.29.1</jersey.server.version>
<jersey.client.version>2.28</jersey.client.version>
<jackson.version>2.10.3</jackson.version>
+ <jackson-databind.version>2.9.10.8</jackson-databind.version>
Review comment:
Could we possibly get rid of `jackson-databind.version` now? I think we didn't originally have that, but at one point there was a special fourth digit release of `jackson-databind` that didn't exist for `jackson-core`. Seems like now we could possibly get them back in sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] exceptionfactory commented on a change in pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318#discussion_r596029135
##########
File path: pom.xml
##########
@@ -92,11 +92,12 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<inceptionYear>2017</inceptionYear>
<org.slf4j.version>1.7.30</org.slf4j.version>
- <jetty.version>9.4.19.v20190610</jetty.version>
+ <jetty.version>9.4.38.v20210224</jetty.version>
<jax.rs.api.version>2.1</jax.rs.api.version>
<jersey.server.version>2.29.1</jersey.server.version>
<jersey.client.version>2.28</jersey.client.version>
<jackson.version>2.10.3</jackson.version>
+ <jackson-databind.version>2.9.10.8</jackson-databind.version>
Review comment:
Is there a reason for not updating both `jackson-core` and `jackson-databind` to a more recent version? Both libraries have version `2.12.2` available as of 2021-03-03. At minimum, it seems like it would be best to keep the minor version the same between `jackson-core` and `jackson-databind` as opposed to having `2.10` for `jackson-core` and `2.9` for `jackson-databind`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] asfgit closed pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] thenatog commented on a change in pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
thenatog commented on a change in pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318#discussion_r596221588
##########
File path: pom.xml
##########
@@ -92,11 +92,12 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<inceptionYear>2017</inceptionYear>
<org.slf4j.version>1.7.30</org.slf4j.version>
- <jetty.version>9.4.19.v20190610</jetty.version>
+ <jetty.version>9.4.38.v20210224</jetty.version>
<jax.rs.api.version>2.1</jax.rs.api.version>
<jersey.server.version>2.29.1</jersey.server.version>
<jersey.client.version>2.28</jersey.client.version>
<jackson.version>2.10.3</jackson.version>
+ <jackson-databind.version>2.9.10.8</jackson-databind.version>
Review comment:
@bbende I'll see what I can do to remove the 'jackson-databind' version property for NiFi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] exceptionfactory commented on pull request #318: NIFIREG-447 - Upgrade direct dependencies.
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #318:
URL: https://github.com/apache/nifi-registry/pull/318#issuecomment-801297459
Thanks for the additional updates @mtien-apache. Verified successful build and application runtime behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org