You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rehevkor5 <gi...@git.apache.org> on 2016/08/08 20:29:32 UTC
[GitHub] flink pull request #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoo...
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/2341
[FLINK-4334] [quickstarts] Correctly exclude hadoop1 in quickstart POMs
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink fix_hadoop1_not_excluded_in_quickstarts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2341.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2341
----
commit 8cb7419a17359f0d61d632aae97f672d497ccc53
Author: Shannon Carey <re...@gmail.com>
Date: 2016-08-08T20:04:23Z
[FLINK-4334] [quickstarts] Correctly exclude hadoop1 in quickstart POMs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoop1 in q...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2341
Thanks, this makes a lot of sense.
We should merge this for Flink 1.1.1
For Flink 1.2.0, we should actually fix the root issue, which is that the hadoop1 artifact has a scala suffix even though it does not need one. I think this was introduced by accident.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoop1 in q...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2341
I merged this into the 1.1 release branch.
For the 1.2 releases, we should use this fix: #2343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoop1 in q...
Posted by rehevkor5 <gi...@git.apache.org>.
Github user rehevkor5 commented on the issue:
https://github.com/apache/flink/pull/2341
You got it @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoo...
Posted by rehevkor5 <gi...@git.apache.org>.
Github user rehevkor5 closed the pull request at:
https://github.com/apache/flink/pull/2341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoop1 in q...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2341
@rehevkor5 Since the Apache bot does not automatically close this pull request, could you close it manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---