You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/08/10 21:25:05 UTC

[GitHub] spark pull request #18724: [SPARK-21519][SQL] Add an option to the JDBC data...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18724#discussion_r132572082
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala ---
    @@ -1007,4 +1007,14 @@ class JDBCSuite extends SparkFunSuite
           assert(sql("select * from people_view").count() == 3)
         }
       }
    +
    +  test("SPARK-21519: option sessionInitStatement, run SQL to initialize the database session.") {
    +    val initSQL = "SET @MYTESTVAR 21519"
    --- End diff --
    
    Could we add a test case for more than one statements?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org