You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by dhasenan <gi...@git.apache.org> on 2017/10/21 15:38:10 UTC

[GitHub] thrift pull request #1396: THRIFT-4305 Doc comments in dlang output

GitHub user dhasenan opened a pull request:

    https://github.com/apache/thrift/pull/1396

    THRIFT-4305 Doc comments in dlang output

    Thrift IDL supports documentation comments. D supports doc comments.
    So let's copy them over!
    
    Future directions: add function parameter docs. ddoc expects them in
    a particular format.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhasenan/thrift THRIFT-4305

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1396
    
----
commit eced8542e6900375716ce9dbbfc8ec9c985c27a0
Author: dhasenan <dh...@gmail.com>
Date:   2017-10-21T15:25:14Z

    THRIFT-4305 Doc comments in dlang output
    
    Thrift IDL supports documentation comments. D supports doc comments.
    So let's copy them over!
    
    Future directions: add function parameter docs. ddoc expects them in
    a particular format.

----


---

[GitHub] thrift issue #1396: THRIFT-4305 Doc comments in dlang output

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1396
  
    Manually inspecting the result in a sandbox.


---

[GitHub] thrift pull request #1396: THRIFT-4305 Doc comments in dlang output

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1396


---