You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 14:58:14 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #8706: ARROW-10032: [Documentation] update C++ windows docs
pitrou commented on a change in pull request #8706:
URL: https://github.com/apache/arrow/pull/8706#discussion_r528763294
##########
File path: docs/source/developers/cpp/windows.rst
##########
@@ -273,19 +273,28 @@ tests can be made with there individual make targets).
1. Microsoft offers trial VMs for `Windows with Microsoft Visual Studio
<https://developer.microsoft.com/en-us/windows/downloads/virtual-machines>`_.
Download and install a version.
-2. Run the VM and install CMake and Miniconda or Anaconda (these instructions
- assume Anaconda).
+2. Run the VM and install `Git <https://git-scm.com/>`, `CMake
+ <https://cmake.org/>`, and Miniconda or Anaconda (these instructions assume
+ Anaconda). Also install the `"Build Tools for Visual Studio"
+ <https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019>`_.
+ Make sure to select the C++ toolchain in the installer wizard, and reboot
+ after installation.
Review comment:
```suggestion
2. Run the VM and install `Git <https://git-scm.com/>`_, `CMake
<https://cmake.org/>`_, and Miniconda or Anaconda (these instructions assume
Anaconda). Also install the `"Build Tools for Visual Studio"
<https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019>`_.
Make sure to select the C++ toolchain in the installer wizard, and reboot
after installation.
```
(fix ReST hyperlink syntax)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org