You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org> on 2019/01/09 22:28:19 UTC

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency 

Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12203


Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................

IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

This patch is a temporary fix to disable tests which fail due to
S3's eventually consistent behavior. The permanent fix would
involve running tests with S3Guard enabled.

Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
---
M tests/metadata/test_compute_stats.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_nested_types.py
4 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/12203/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12203/2/tests/query_test/test_insert.py
File tests/query_test/test_insert.py:

http://gerrit.cloudera.org:8080/#/c/12203/2/tests/query_test/test_insert.py@26
PS2, Line 26: 
> flake8: E501 line too long (99 > 90 characters)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 05:23:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................

IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

This patch is a temporary fix to disable tests which fail due to
S3's eventually consistent behavior. The permanent fix would
involve running tests with S3Guard enabled.

Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
---
M tests/metadata/test_compute_stats.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_nested_types.py
4 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/12203/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Jan 2019 03:42:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert.py
File tests/query_test/test_insert.py:

http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert.py@152
PS1, Line 152: S
flake8: F821 undefined name 'SkipIfS3'


http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert_permutation.py
File tests/query_test/test_insert_permutation.py:

http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert_permutation.py@48
PS1, Line 48: S
flake8: F821 undefined name 'SkipIfS3'



-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 22:29:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 23:37:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3: Code-Review+2

It makes sense to disable these flaky tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 18:39:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3635/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 23:37:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1757/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 23:02:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1756/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 23:03:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review+1
> 
> LGTM, how did you determine the list of tests to disable?

I looked at the recent failed builds and disabled the tests which failed due to consistency issues. We might (most likely) have more such tests. I plan on working on the long term fix soon.


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 20:36:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3: Code-Review+1

LGTM, how did you determine the list of tests to disable?


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 20:24:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................

IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

This patch is a temporary fix to disable tests which fail due to
S3's eventually consistent behavior. The permanent fix would
involve running tests with S3Guard enabled.

Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
---
M tests/metadata/test_compute_stats.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_nested_types.py
4 files changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/12203/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 22:44:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert.py
File tests/query_test/test_insert.py:

http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert.py@152
PS1, Line 152: S
> flake8: F821 undefined name 'SkipIfS3'
Done


http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert_permutation.py
File tests/query_test/test_insert_permutation.py:

http://gerrit.cloudera.org:8080/#/c/12203/1/tests/query_test/test_insert_permutation.py@48
PS1, Line 48: 
> flake8: F821 undefined name 'SkipIfS3'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 22:32:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1763/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 05:57:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3633/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 18:45:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12203/2/tests/query_test/test_insert.py
File tests/query_test/test_insert.py:

http://gerrit.cloudera.org:8080/#/c/12203/2/tests/query_test/test_insert.py@26
PS2, Line 26:  
flake8: E501 line too long (99 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 22:33:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12203 )

Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency
......................................................................

IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

This patch is a temporary fix to disable tests which fail due to
S3's eventually consistent behavior. The permanent fix would
involve running tests with S3Guard enabled.

Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Reviewed-on: http://gerrit.cloudera.org:8080/12203
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_compute_stats.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_nested_types.py
4 files changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I676faa191bec8b156e430661c22ee69242eeba9d
Gerrit-Change-Number: 12203
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>