[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8164: [wip] More detailed async error messages for sqllab

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8164: [wip] More detailed async error messages for sqllab
URL: https://github.com/apache/incubator-superset/pull/8164#discussion_r321500970
 
 

 ##########
 File path: superset/db_engine_specs/base.py
 ##########
 @@ -476,7 +476,11 @@ def handle_cursor(cls, cursor, query, session):
         pass
 
     @classmethod
-    def extract_error_message(cls, e: Exception) -> str:
+    def extract_error_message(cls, e: Exception):
 
 Review comment:
   pls add a return type here! `-> str`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org