[jira] [Commented] (XERCESC-2208) Rationalise XercesIntTypes

["Roger Leigh (Jira)" <xe...@xml.apache.org>]

    [ https://issues.apache.org/jira/browse/XERCESC-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134809#comment-17134809 ] 

Roger Leigh commented on XERCESC-2208:
--------------------------------------

Please see open pull request for this change.

* Unconditionally use <cstdint>. Also use <cstddef> and <cwchar>.
* Remove Autoconf and CMake integer checks, along with some other unused header checks and defines present in Xerces_autoconf_config.hpp
* Move constant type definitions out of Xerces_autoconf_config.hpp into XercesDefs.hpp
* UTF16Ch and UCS4Ch are typedefs for char16_t and char32_t, so are now using the language types specifically intended for the purpose
* XSValue now uses fixed-size integer types, so its behaviour will be the same across all platforms.

Some review, testing and feedback would certainly be appreciated.  In particular, testing on a 32-bit platform would be very useful.

> Rationalise XercesIntTypes
> --------------------------
>
>                 Key: XERCESC-2208
>                 URL: https://issues.apache.org/jira/browse/XERCESC-2208
>             Project: Xerces-C++
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 3.3.0
>            Reporter: Roger Leigh
>            Assignee: Roger Leigh
>            Priority: Major
>             Fix For: 3.3.0
>
>
> We currently have multiple fallbacks for int types from cstdint, stdint.h, inttypes.h etc.  However, if we require cstdint then we have most of the basic types guaranteed to be provided, and most of the logic to handle the fallbacks can be eliminated entirely.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org