You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Albert Strasheim (JIRA)" <ji...@apache.org> on 2007/03/16 10:32:34 UTC
[jira] Created: (AMQCPP-89) Case of cms::Message getter and setter
names are not consistent with case of JMS Message getter and setter names
Case of cms::Message getter and setter names are not consistent with case of JMS Message getter and setter names
----------------------------------------------------------------------------------------------------------------
Key: AMQCPP-89
URL: https://issues.apache.org/activemq/browse/AMQCPP-89
Project: ActiveMQ C++ Client
Issue Type: Improvement
Components: CMS Impl
Affects Versions: 2.0
Reporter: Albert Strasheim
Assigned To: Nathan Mittler
Priority: Minor
Fix For: 2.0
The cms::Message getter and setter names could be more consistent with the JMS Message getter and setter names. It makes sense that JMS is replaced with CMS, but there are case inconsistencies that are slightly suboptimal.
* getJMSCorrelationID vs getCMSCorrelationId
* setJMSCorrelationID vs setCMSCorrelationId
* getJMSMessageID vs setCMSMessageId
* getJMSTimestamp vs getCMSTimeStamp
I think it might be worth fixing these for the 2.0 release. It's especially useful when one quickly wants to port over a bit of JMS code to CMS.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQCPP-89) Case of cms::Message getter and setter
names are not consistent with case of JMS Message getter and setter names
Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Mittler resolved AMQCPP-89.
----------------------------------
Resolution: Fixed
I've fixed the Timestamp method names as well as a few others. I've also added better comments to Message.h (taken from the JMS 1.1 API) to make it more clear what certain methods do without having to cross-reference with JMS.
> Case of cms::Message getter and setter names are not consistent with case of JMS Message getter and setter names
> ----------------------------------------------------------------------------------------------------------------
>
> Key: AMQCPP-89
> URL: https://issues.apache.org/activemq/browse/AMQCPP-89
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Components: CMS Impl
> Affects Versions: 2.0
> Reporter: Albert Strasheim
> Assigned To: Nathan Mittler
> Priority: Minor
> Fix For: 2.0
>
>
> The cms::Message getter and setter names could be more consistent with the JMS Message getter and setter names. It makes sense that JMS is replaced with CMS, but there are case inconsistencies that are slightly suboptimal.
> * getJMSCorrelationID vs getCMSCorrelationId
> * setJMSCorrelationID vs setCMSCorrelationId
> * getJMSMessageID vs setCMSMessageId
> * getJMSTimestamp vs getCMSTimeStamp
> I think it might be worth fixing these for the 2.0 release. It's especially useful when one quickly wants to port over a bit of JMS code to CMS.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (AMQCPP-89) Case of cms::Message getter and setter
names are not consistent with case of JMS Message getter and setter names
Posted by "Albert Strasheim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Albert Strasheim reopened AMQCPP-89:
------------------------------------
Looks like you might have missed getCMSTimeStamp/setCMSTimeStamp. JMS Message spells it "Timestamp".
> Case of cms::Message getter and setter names are not consistent with case of JMS Message getter and setter names
> ----------------------------------------------------------------------------------------------------------------
>
> Key: AMQCPP-89
> URL: https://issues.apache.org/activemq/browse/AMQCPP-89
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Components: CMS Impl
> Affects Versions: 2.0
> Reporter: Albert Strasheim
> Assigned To: Nathan Mittler
> Priority: Minor
> Fix For: 2.0
>
>
> The cms::Message getter and setter names could be more consistent with the JMS Message getter and setter names. It makes sense that JMS is replaced with CMS, but there are case inconsistencies that are slightly suboptimal.
> * getJMSCorrelationID vs getCMSCorrelationId
> * setJMSCorrelationID vs setCMSCorrelationId
> * getJMSMessageID vs setCMSMessageId
> * getJMSTimestamp vs getCMSTimeStamp
> I think it might be worth fixing these for the 2.0 release. It's especially useful when one quickly wants to port over a bit of JMS code to CMS.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQCPP-89) Case of cms::Message getter and setter
names are not consistent with case of JMS Message getter and setter names
Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Mittler resolved AMQCPP-89.
----------------------------------
Resolution: Fixed
fixed in trunk
> Case of cms::Message getter and setter names are not consistent with case of JMS Message getter and setter names
> ----------------------------------------------------------------------------------------------------------------
>
> Key: AMQCPP-89
> URL: https://issues.apache.org/activemq/browse/AMQCPP-89
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Components: CMS Impl
> Affects Versions: 2.0
> Reporter: Albert Strasheim
> Assigned To: Nathan Mittler
> Priority: Minor
> Fix For: 2.0
>
>
> The cms::Message getter and setter names could be more consistent with the JMS Message getter and setter names. It makes sense that JMS is replaced with CMS, but there are case inconsistencies that are slightly suboptimal.
> * getJMSCorrelationID vs getCMSCorrelationId
> * setJMSCorrelationID vs setCMSCorrelationId
> * getJMSMessageID vs setCMSMessageId
> * getJMSTimestamp vs getCMSTimeStamp
> I think it might be worth fixing these for the 2.0 release. It's especially useful when one quickly wants to port over a bit of JMS code to CMS.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.