You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/17 11:16:34 UTC

[GitHub] [spark] cloud-fan commented on pull request #29771: [SPARK-32635][SQL] Fix foldable propagation

cloud-fan commented on pull request #29771:
URL: https://github.com/apache/spark/pull/29771#issuecomment-694164741


   > that it might introduce more, unnecessary copies of the logically unchanged nodes
   
   Good point. `mapChildren` takes care of it and we should always use `mapChildren` instead of `node.copy(child = newChild)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org