[GitHub] [spark] gengliangwang commented on a change in pull request #33750: [SPARK-36521][SQL] Disallow comparison between Interval and String

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #33750:
URL: https://github.com/apache/spark/pull/33750#discussion_r689497401



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -862,6 +862,18 @@ object TypeCoercion extends TypeCoercionBase {
     case _ => None
   }
 
+  // Return whether a string literal can be promoted as the give data type in a binary comparison.
+  private def canPromoteAsInBinaryComparison(dt: DataType) = dt match {

Review comment:
       Yes and no. Here is for binary comparison, while in ANSI mode it is for binary operators...It is hard to create a function name for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org