[jira] [Commented] (NUMBERS-149) port functions / tests in commons-lang for Fraction.

["Gilles Sadowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184152#comment-17184152 ] 

Gilles Sadowski commented on NUMBERS-149:
-----------------------------------------

Just browsing the top of the diffs...

This factory method
{code}
public static Fraction of(final int whole, final int numerator, final int denominator)
{code}
is not necessary.
Neither are the many constants ({{ONE_HALF}}, {{ONE_THIRD}}, ...).

Why did you port code marked {{@Deprecated}}?

The {{toString()}} method should not be changed.
String formatting is not part of the intended API.


> port functions / tests in commons-lang for Fraction.
> ----------------------------------------------------
>
>                 Key: NUMBERS-149
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-149
>             Project: Commons Numbers
>          Issue Type: Improvement
>          Components: fraction
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://github.com/apache/commons-numbers/pull/82



--
This message was sent by Atlassian Jira
(v8.3.4#803005)