You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by heary-cao <gi...@git.apache.org> on 2017/05/15 07:37:14 UTC

[GitHub] spark pull request #17984: Unit testing support for ���spark://��� format

GitHub user heary-cao opened a pull request:

    https://github.com/apache/spark/pull/17984

    Unit testing support for ‘spark://’ format

    ## What changes were proposed in this pull request?
    
    This PR adds the new unit tests to support test 'SPARK_REGEX(sparkUrl)' branch in createTaskScheduler methods.  
    
    ## How was this patch tested?
    
    The new unit test.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heary-cao/spark SchedulerCreationSuite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17984.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17984
    
----
commit 5e6332c7cbe62421fceec4525787337283af7bea
Author: caoxuewen <ca...@zte.com.cn>
Date:   2017-05-15T07:31:50Z

    Unit testing support for spark:// format

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TESTS]Unit testing support for ���s...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17984
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit...

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17984#discussion_r116642520
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSchedulerCreationSuite.scala ---
    @@ -129,4 +129,29 @@ class SparkContextSchedulerCreationSuite
           case _ => fail()
         }
       }
    +
    +  test("bad-spark-url") {
    +    val e = intercept[SparkException] {
    +      createTaskScheduler("spark:*")
    --- End diff --
    
    The intent of this test is the spark regex parsing analysis anomalies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit tests ...

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/17984
  
    Sorry,
    surgical test? 
    I didn't understand .
    Can you explain in more detail?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TEST]Unit testing support for ���sp...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17984
  
    OK. It's minor, and not 100% sure this is the best place to test, but, it follows the pattern in the rest of the file and. This didn't need a JIRA, and please see my comments on the JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit tests ...

Posted by sameeragarwal <gi...@git.apache.org>.
Github user sameeragarwal commented on the issue:

    https://github.com/apache/spark/pull/17984
  
    @heary-cao it seems like the additional tests are primarily targeted towards testing [spark regex parsing](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L2731-L2736) while creating a task scheduler . If that's actually the intent, maybe we should have a more surgical test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit...

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao closed the pull request at:

    https://github.com/apache/spark/pull/17984


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit tests ...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17984
  
    He's saying that you're really just testing arg parsing. And it's mostly tested elsewhere, although maybe not this exact case. I don't know if this adds much value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit...

Posted by sameeragarwal <gi...@git.apache.org>.
Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17984#discussion_r116578503
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSchedulerCreationSuite.scala ---
    @@ -129,4 +129,29 @@ class SparkContextSchedulerCreationSuite
           case _ => fail()
         }
       }
    +
    +  test("bad-spark-url") {
    +    val e = intercept[SparkException] {
    +      createTaskScheduler("spark:*")
    --- End diff --
    
    Aren't these tests identical to existing tests above (`bad-master` and `local-default-parallelism`)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17984: [ SPARK-20739][CORE][TEST]Supplement the new unit tests ...

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/17984
  
    ok,
    It does not produce value, that is junk code.
    close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org