You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/31 01:02:29 UTC
[GitHub] [beam] boyuanzz opened a new pull request #14384: [WIP] Changes PubSub translation
boyuanzz opened a new pull request #14384:
URL: https://github.com/apache/beam/pull/14384
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>SDK</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon">
</a>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img src="https://camo.githubusercontent.com/4565d7b7e907114e6c1d12323408bd903aa252fefed5eeab93701b05c9628a84/68747470733a2f2f63692d6265616d2e6170616368652e6f72672f6a6f622f6265616d5f507265436f6d6d69745f507974686f6e446f636b65725f43726f6e2f62616467652f69636f6e" alt="Build Status" data-canonical-src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img src="https://camo.githubusercontent.com/21afb097a5745440598bee5c59a027b140585eec871c3f3b883200610fabf722/68747470733a2f2f63692d6265616d2e6170616368652e6f72672f6a6f622f6265616d5f507265436f6d6d69745f507974686f6e446f63735f43726f6e2f62616467652f69636f6e" alt="Build Status" data-canonical-src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-814367716
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/examples/snippets/snippets.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy9zbmlwcGV0cy5weQ==) | | |
| [...nippets/transforms/aggregation/groupintobatches.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL2dyb3VwaW50b2JhdGNoZXMucHk=) | | |
| [...dks/python/apache\_beam/io/external/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9leHRlcm5hbC9nY3AvX19pbml0X18ucHk=) | | |
| [...ache\_beam/examples/cookbook/bigquery\_side\_input.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb29rYm9vay9iaWdxdWVyeV9zaWRlX2lucHV0LnB5) | | |
| [...py38/build/srcs/sdks/python/apache\_beam/io/jdbc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9qZGJjLnB5) | | |
| [...examples/snippets/transforms/elementwise/filter.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2VsZW1lbnR3aXNlL2ZpbHRlci5weQ==) | | |
| [.../python/apache\_beam/io/gcp/bigquery\_io\_metadata.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfaW9fbWV0YWRhdGEucHk=) | | |
| [...s/python/apache\_beam/runners/worker/log\_handler.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9sb2dfaGFuZGxlci5weQ==) | | |
| [...hon/apache\_beam/examples/complete/game/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9nYW1lL19faW5pdF9fLnB5) | | |
| [...ache\_beam/examples/cookbook/datastore\_wordcount.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb29rYm9vay9kYXRhc3RvcmVfd29yZGNvdW50LnB5) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-816034204
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...srcs/sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvZG9jdGVzdHMucHk=) | | |
| [...x/py38/build/srcs/sdks/python/apache\_beam/error.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9lcnJvci5weQ==) | | |
| [...sdks/python/apache\_beam/internal/gcp/json\_value.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pbnRlcm5hbC9nY3AvanNvbl92YWx1ZS5weQ==) | | |
| [...ld/srcs/sdks/python/apache\_beam/io/aws/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9hd3MvX19pbml0X18ucHk=) | | |
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvZXh0ZXJuYWxfdHJhbnNmb3Jtc19wYjJfZ3JwYy5weQ==) | | |
| [...ers/dataflow/dataflow\_exercise\_metrics\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93X2V4ZXJjaXNlX21ldHJpY3NfcGlwZWxpbmUucHk=) | | |
| [...hon/apache\_beam/io/gcp/datastore/v1new/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvZGF0YXN0b3JlL3YxbmV3L19faW5pdF9fLnB5) | | |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | | |
| [...uild/srcs/sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9jb2RlcnMvY29kZXJzLnB5) | | |
| [...beam/testing/benchmarks/nexmark/queries/query10.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9xdWVyaWVzL3F1ZXJ5MTAucHk=) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-811638941
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (112c843) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 112c843 differs from pull request most recent head 740616b. Consider uploading reports for the commit 740616b to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.45% -0.01%
==========================================
Files 470 470
Lines 59001 59001
==========================================
- Hits 49239 49237 -2
- Misses 9762 9764 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...srcs/sdks/python/apache\_beam/io/filebasedsource.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9maWxlYmFzZWRzb3VyY2UucHk=) | | |
| [...ers/interactive/testing/integration/screen\_diff.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3Rlc3RpbmcvaW50ZWdyYXRpb24vc2NyZWVuX2RpZmYucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvb3Bjb2Rlcy5weQ==) | | |
| [.../python/apache\_beam/io/gcp/bigquery\_io\_metadata.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfaW9fbWV0YWRhdGEucHk=) | | |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L2ZuX2FwaV9ydW5uZXIvZXhlY3V0aW9uLnB5) | | |
| [.../runners/interactive/testing/pipeline\_assertion.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3Rlc3RpbmcvcGlwZWxpbmVfYXNzZXJ0aW9uLnB5) | | |
| [.../python/apache\_beam/io/gcp/tests/pubsub\_matcher.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvdGVzdHMvcHVic3ViX21hdGNoZXIucHk=) | | |
| [...apache\_beam/testing/benchmarks/nexmark/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9fX2luaXRfXy5weQ==) | | |
| [...ython/apache\_beam/examples/kafkataxi/kafka\_taxi.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9rYWZrYXRheGkva2Fma2FfdGF4aS5weQ==) | | |
| [...ks/python/apache\_beam/examples/cookbook/filters.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb29rYm9vay9maWx0ZXJzLnB5) | | |
| ... and [930 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...740616b](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head bbce792 differs from pull request most recent head c472530. Consider uploading reports for the commit c472530 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../build/srcs/sdks/python/apache\_beam/io/aws/s3io.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9hd3MvczNpby5weQ==) | | |
| [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93X21ldHJpY3MucHk=) | | |
| [...python/apache\_beam/transforms/external\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2V4dGVybmFsX3Rlc3RfcHkzLnB5) | | |
| [...examples/snippets/transforms/aggregation/sample.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL3NhbXBsZS5weQ==) | | |
| [...mples/snippets/transforms/elementwise/partition.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2VsZW1lbnR3aXNlL3BhcnRpdGlvbi5weQ==) | | |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L2ludGVybmFsL2FwaWNsaWVudC5weQ==) | | |
| [...\_beam/io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvaW50ZXJuYWwvY2xpZW50cy9iaWdxdWVyeS9fX2luaXRfXy5weQ==) | | |
| [...m/testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvY2hpY2Fnb190YXhpL3RyYWluZXIvbW9kZWwucHk=) | | |
| [...dks/python/apache\_beam/io/external/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9leHRlcm5hbC9nY3AvX19pbml0X18ucHk=) | | |
| [...hon/apache\_beam/examples/wordcount\_with\_metrics.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy93b3JkY291bnRfd2l0aF9tZXRyaWNzLnB5) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...c472530](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-811638853
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 740616b differs from pull request most recent head 797d459. Consider uploading reports for the commit 797d459 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...797d459](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 740616b differs from pull request most recent head 797d459. Consider uploading reports for the commit 797d459 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...797d459](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...st-suites/tox/py38/build/srcs/sdks/python/setup.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9zZXR1cC5weQ==) | | |
| [...cs/sdks/python/apache\_beam/transforms/userstate.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL3VzZXJzdGF0ZS5weQ==) | | |
| [...ld/srcs/sdks/python/apache\_beam/transforms/core.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2NvcmUucHk=) | | |
| [...che\_beam/portability/api/beam\_expansion\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvYmVhbV9leHBhbnNpb25fYXBpX3BiMi5weQ==) | | |
| [...on/apache\_beam/examples/complete/juliaset/setup.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9qdWxpYXNldC9zZXR1cC5weQ==) | | |
| [...srcs/sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9tZXRyaWNzL21ldHJpY2Jhc2UucHk=) | | |
| [...n/apache\_beam/runners/dataflow/native\_io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L25hdGl2ZV9pby9pb2Jhc2UucHk=) | | |
| [...ache\_beam/examples/snippets/transforms/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL19faW5pdF9fLnB5) | | |
| [...s/sdks/python/apache\_beam/examples/avro\_bitcoin.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9hdnJvX2JpdGNvaW4ucHk=) | | |
| [...hon/apache\_beam/examples/complete/game/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9nYW1lL19faW5pdF9fLnB5) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvYmVhbV9mbl9hcGlfcGIyX2dycGMucHk=) | | |
| [...am/examples/complete/juliaset/juliaset/juliaset.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9qdWxpYXNldC9qdWxpYXNldC9qdWxpYXNldC5weQ==) | | |
| [...on/apache\_beam/portability/api/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvYmVhbV9qb2JfYXBpX3BiMi5weQ==) | | |
| [...py38/build/srcs/sdks/python/apache\_beam/io/jdbc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9qZGJjLnB5) | | |
| [...on/apache\_beam/runners/worker/statesampler\_slow.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zdGF0ZXNhbXBsZXJfc2xvdy5weQ==) | | |
| [...e\_beam/io/gcp/big\_query\_query\_to\_table\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlnX3F1ZXJ5X3F1ZXJ5X3RvX3RhYmxlX3BpcGVsaW5lLnB5) | | |
| [.../srcs/sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9jb2RlcnMvdHlwZWNvZGVycy5weQ==) | | |
| [.../python/apache\_beam/runners/worker/statesampler.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zdGF0ZXNhbXBsZXIucHk=) | | |
| [...y38/build/srcs/sdks/python/apache\_beam/io/utils.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby91dGlscy5weQ==) | | |
| [...m/examples/snippets/transforms/aggregation/mean.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL21lYW4ucHk=) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (112c843) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.45% -0.01%
==========================================
Files 470 470
Lines 59001 59001
==========================================
- Hits 49239 49237 -2
- Misses 9762 9764 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9jb21tb25fdXJucy5weQ==) | | |
| [...suites/tox/py38/build/srcs/sdks/python/conftest.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9jb25mdGVzdC5weQ==) | | |
| [...python/apache\_beam/runners/portability/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L19faW5pdF9fLnB5) | | |
| [...d/srcs/sdks/python/apache\_beam/options/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9vcHRpb25zL19faW5pdF9fLnB5) | | |
| [...sdks/python/apache\_beam/io/aws/clients/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9hd3MvY2xpZW50cy9fX2luaXRfXy5weQ==) | | |
| [...beam/testing/benchmarks/chicago\_taxi/preprocess.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvY2hpY2Fnb190YXhpL3ByZXByb2Nlc3MucHk=) | | |
| [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93X21ldHJpY3MucHk=) | | |
| [...ache\_beam/examples/cookbook/bigquery\_side\_input.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb29rYm9vay9iaWdxdWVyeV9zaWRlX2lucHV0LnB5) | | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvc3RhbmRhcmRfd2luZG93X2Zuc19wYjJfdXJucy5weQ==) | | |
| [...beam/runners/portability/fn\_api\_runner/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L2ZuX2FwaV9ydW5uZXIvX19pbml0X18ucHk=) | | |
| ... and [930 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...112c843](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (1948f70) into [master](https://codecov.io/gh/apache/beam/commit/10f5cbc6d7eb6de41c24b13471390588b1dd2b1c?el=desc) (10f5cbc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.16% 83.14% -0.02%
==========================================
Files 469 469
Lines 58914 58914
==========================================
- Hits 48993 48985 -8
- Misses 9921 9929 +8
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../srcs/sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvdG9fdXRpbHMucHk=) | | |
| [...ache\_beam/runners/portability/expansion\_service.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9leHBhbnNpb25fc2VydmljZS5weQ==) | | |
| [.../srcs/sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | | |
| [...s/sdks/python/apache\_beam/transforms/sideinputs.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zaWRlaW5wdXRzLnB5) | | |
| [...x/py38/build/srcs/sdks/python/apache\_beam/error.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXJyb3IucHk=) | | |
| [...n/apache\_beam/runners/dataflow/native\_io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9uYXRpdmVfaW8vaW9iYXNlLnB5) | | |
| [...d/srcs/sdks/python/apache\_beam/io/filebasedsink.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWJhc2Vkc2luay5weQ==) | | |
| [...ive/messaging/interactive\_environment\_inspector.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9tZXNzYWdpbmcvaW50ZXJhY3RpdmVfZW52aXJvbm1lbnRfaW5zcGVjdG9yLnB5) | | |
| [.../srcs/sdks/python/apache\_beam/dataframe/schemas.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3NjaGVtYXMucHk=) | | |
| [...srcs/sdks/python/apache\_beam/typehints/row\_type.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3Jvd190eXBlLnB5) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [10f5cbc...1948f70](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 740616b differs from pull request most recent head e8666a0. Consider uploading reports for the commit e8666a0 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...e8666a0](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-811507695
Within this changes:
the read from pubsub proto looks like:
The write to pubsub proto looks like:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-815183011
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (112c843) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.45% -0.01%
==========================================
Files 470 470
Lines 59001 59001
==========================================
- Hits 49239 49237 -2
- Misses 9762 9764 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvZ2NzaW9fb3ZlcnJpZGVzLnB5) | | |
| [...ks/python/apache\_beam/io/gcp/pubsub\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvcHVic3ViX2l0X3BpcGVsaW5lLnB5) | | |
| [...he\_beam/testing/benchmarks/nexmark/nexmark\_perf.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9uZXhtYXJrX3BlcmYucHk=) | | |
| [.../python/apache\_beam/examples/kafkataxi/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9rYWZrYXRheGkvX19pbml0X18ucHk=) | | |
| [...am/testing/benchmarks/chicago\_taxi/trainer/task.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvY2hpY2Fnb190YXhpL3RyYWluZXIvdGFzay5weQ==) | | |
| [...es/snippets/transforms/aggregation/cogroupbykey.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL2NvZ3JvdXBieWtleS5weQ==) | | |
| [...suites/tox/py38/build/srcs/sdks/python/conftest.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9jb25mdGVzdC5weQ==) | | |
| [...ld/srcs/sdks/python/apache\_beam/io/filesystemio.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9maWxlc3lzdGVtaW8ucHk=) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9xdWVyaWVzL3F1ZXJ5Mi5weQ==) | | |
| [...dks/python/apache\_beam/testing/extra\_assertions.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2V4dHJhX2Fzc2VydGlvbnMucHk=) | | |
| ... and [930 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...112c843](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-816002358
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-813554168
Java precommit errors seem unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-813554702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (1948f70) into [master](https://codecov.io/gh/apache/beam/commit/10f5cbc6d7eb6de41c24b13471390588b1dd2b1c?el=desc) (10f5cbc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.16% 83.14% -0.02%
==========================================
Files 469 469
Lines 58914 58914
==========================================
- Hits 48993 48985 -8
- Misses 9921 9929 +8
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e\_beam/examples/complete/juliaset/juliaset\_main.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXRfbWFpbi5weQ==) | | |
| [...cs/sdks/python/apache\_beam/io/gcp/gcsfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2ZpbGVzeXN0ZW0ucHk=) | | |
| [...srcs/sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | | |
| [...ild/srcs/sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | | |
| [...m/testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL21vZGVsLnB5) | | |
| [...s/python/apache\_beam/runners/worker/log\_handler.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvbG9nX2hhbmRsZXIucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvdG9fdXRpbHMucHk=) | | |
| [...s/python/apache\_beam/portability/api/schema\_pb2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3NjaGVtYV9wYjIucHk=) | | |
| [...srcs/sdks/python/apache\_beam/io/gcp/dicomclient.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RpY29tY2xpZW50LnB5) | | |
| [...ild/srcs/sdks/python/apache\_beam/io/gcp/dicomio.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RpY29taW8ucHk=) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [10f5cbc...1948f70](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (1948f70) into [master](https://codecov.io/gh/apache/beam/commit/10f5cbc6d7eb6de41c24b13471390588b1dd2b1c?el=desc) (10f5cbc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.16% 83.14% -0.02%
==========================================
Files 469 469
Lines 58914 58914
==========================================
- Hits 48993 48985 -8
- Misses 9921 9929 +8
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...beam/portability/api/beam\_artifact\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl9ncnBjLnB5) | | |
| [...e\_beam/examples/complete/game/hourly\_team\_score.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9ob3VybHlfdGVhbV9zY29yZS5weQ==) | | |
| [...srcs/sdks/python/apache\_beam/transforms/display.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9kaXNwbGF5LnB5) | | |
| [...ks/python/apache\_beam/coders/coders\_test\_common.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyc190ZXN0X2NvbW1vbi5weQ==) | | |
| [...apache\_beam/examples/cookbook/custom\_ptransform.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svY3VzdG9tX3B0cmFuc2Zvcm0ucHk=) | | |
| [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | | |
| [...sdks/python/apache\_beam/dataframe/partitionings.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3BhcnRpdGlvbmluZ3MucHk=) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTIucHk=) | | |
| [...ks/python/apache\_beam/internal/metrics/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9fX2luaXRfXy5weQ==) | | |
| [...pache\_beam/runners/interactive/caching/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL19faW5pdF9fLnB5) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [10f5cbc...1948f70](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-816185270
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (1948f70) into [master](https://codecov.io/gh/apache/beam/commit/10f5cbc6d7eb6de41c24b13471390588b1dd2b1c?el=desc) (10f5cbc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.16% 83.14% -0.02%
==========================================
Files 469 469
Lines 58914 58914
==========================================
- Hits 48993 48985 -8
- Misses 9921 9929 +8
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../build/srcs/sdks/python/apache\_beam/io/aws/s3io.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL3MzaW8ucHk=) | | |
| [...che\_beam/examples/flink/flink\_streaming\_impulse.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvZmxpbmsvZmxpbmtfc3RyZWFtaW5nX2ltcHVsc2UucHk=) | | |
| [...rcs/sdks/python/apache\_beam/testing/test\_stream.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbS5weQ==) | | |
| [...amples/snippets/transforms/aggregation/distinct.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9kaXN0aW5jdC5weQ==) | | |
| [...srcs/sdks/python/apache\_beam/transforms/display.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9kaXNwbGF5LnB5) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query9.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTkucHk=) | | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | | |
| [...dks/python/apache\_beam/examples/wordcount\_xlang.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvd29yZGNvdW50X3hsYW5nLnB5) | | |
| [...s/sdks/python/apache\_beam/internal/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL19faW5pdF9fLnB5) | | |
| [...ers/dataflow/internal/clients/dataflow/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L19faW5pdF9fLnB5) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [10f5cbc...1948f70](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-813498878
retest all please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-814339519
cc: @y1chi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #14384:
URL: https://github.com/apache/beam/pull/14384#discussion_r605736437
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubUnboundedSource.java
##########
@@ -1336,14 +1334,40 @@ public boolean getNeedsMessageId() {
@Override
public PCollection<PubsubMessage> expand(PBegin input) {
- return input
- .getPipeline()
- .begin()
- .apply(Read.from(new PubsubSource(this)))
- .apply(
- "PubsubUnboundedSource.Stats",
- ParDo.of(
- new StatsFn(pubsubFactory, subscription, topic, timestampAttribute, idAttribute)));
+ SerializableFunction<byte[], PubsubMessage> function;
+ if (getNeedsAttributes() || getNeedsMessageId()) {
+ function = new PubsubMessages.ParsePubsubMessageProtoAsPayload();
+ } else {
+ function = new DeserializeBytesIntoPubsubMessagePayloadOnly();
+ }
+ PCollection<PubsubMessage> messages =
+ input
+ .getPipeline()
+ .begin()
+ .apply(Read.from(new PubsubSource(this)))
+ .apply(
+ "MapBytesToPubsubMessages",
+ MapElements.into(TypeDescriptor.of(PubsubMessage.class)).via(function));
+ if (usesStatsFn(input.getPipeline().getOptions())) {
+ checkArgument(false);
Review comment:
Now that I look more closely in the morning it seems there are debugging items left in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on a change in pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on a change in pull request #14384:
URL: https://github.com/apache/beam/pull/14384#discussion_r605780315
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubUnboundedSource.java
##########
@@ -1336,14 +1334,40 @@ public boolean getNeedsMessageId() {
@Override
public PCollection<PubsubMessage> expand(PBegin input) {
- return input
- .getPipeline()
- .begin()
- .apply(Read.from(new PubsubSource(this)))
- .apply(
- "PubsubUnboundedSource.Stats",
- ParDo.of(
- new StatsFn(pubsubFactory, subscription, topic, timestampAttribute, idAttribute)));
+ SerializableFunction<byte[], PubsubMessage> function;
+ if (getNeedsAttributes() || getNeedsMessageId()) {
+ function = new PubsubMessages.ParsePubsubMessageProtoAsPayload();
+ } else {
+ function = new DeserializeBytesIntoPubsubMessagePayloadOnly();
+ }
+ PCollection<PubsubMessage> messages =
+ input
+ .getPipeline()
+ .begin()
+ .apply(Read.from(new PubsubSource(this)))
+ .apply(
+ "MapBytesToPubsubMessages",
+ MapElements.into(TypeDescriptor.of(PubsubMessage.class)).via(function));
+ if (usesStatsFn(input.getPipeline().getOptions())) {
+ checkArgument(false);
Review comment:
Yeah...I'll remove these and fix the tests. Will let you know it's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 740616b differs from pull request most recent head bbce792. Consider uploading reports for the commit bbce792 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-811510550
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #14384:
URL: https://github.com/apache/beam/pull/14384#discussion_r605373972
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.pubsub;
+
+import com.google.auto.service.AutoService;
+import java.util.Collections;
+import java.util.Map;
+import org.apache.beam.model.pipeline.v1.RunnerApi;
+import org.apache.beam.model.pipeline.v1.RunnerApi.FunctionSpec;
+import org.apache.beam.model.pipeline.v1.RunnerApi.PubSubReadPayload;
+import org.apache.beam.model.pipeline.v1.RunnerApi.PubSubWritePayload;
+import org.apache.beam.runners.core.construction.PTransformTranslation;
+import org.apache.beam.runners.core.construction.PTransformTranslation.TransformPayloadTranslator;
+import org.apache.beam.runners.core.construction.SdkComponents;
+import org.apache.beam.runners.core.construction.TransformPayloadTranslatorRegistrar;
+import org.apache.beam.sdk.io.Read;
+import org.apache.beam.sdk.io.Read.Unbounded;
+import org.apache.beam.sdk.io.gcp.pubsub.PubsubClient.SubscriptionPath;
+import org.apache.beam.sdk.io.gcp.pubsub.PubsubClient.TopicPath;
+import org.apache.beam.sdk.io.gcp.pubsub.PubsubUnboundedSource.PubsubSource;
+import org.apache.beam.sdk.options.ValueProvider;
+import org.apache.beam.sdk.options.ValueProvider.NestedValueProvider;
+import org.apache.beam.sdk.runners.AppliedPTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+
+@SuppressWarnings({
+ "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+ "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+})
+/**
+ * Utility methods for translating a {@link Unbounded} which reads from {@link
+ * PubsubUnboundedSource} to {@link RunnerApi} representations.
+ */
+public class PubSubPayloadTranslation {
Review comment:
This is actually fine and intended. We intend for third party IO authors to be able to create proto translations. We only have `runners-core-construction` separate from the core SDK to avoid having a dependency on protobuf. (And that actually seems irrelevant now. But when we started it seemed to matter. I think dev@ has agreed we could merge them now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-811510699
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #14384:
URL: https://github.com/apache/beam/pull/14384#discussion_r605374131
##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -953,7 +913,7 @@ public DataflowPipelineJob run(Pipeline pipeline) {
if (!experiments.contains("beam_fn_api")) {
experiments.add("beam_fn_api");
}
- if (!experiments.contains("use_portable_job_submission")) {
+ if (!experiments.contains("use_portable_jobf_submission")) {
Review comment:
typo: `jobf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz merged pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz merged pull request #14384:
URL: https://github.com/apache/beam/pull/14384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (1948f70) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.30%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 1948f70 differs from pull request most recent head 112c843. Consider uploading reports for the commit 112c843 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.14% -0.31%
==========================================
Files 470 469 -1
Lines 59001 58914 -87
==========================================
- Hits 49239 48985 -254
- Misses 9762 9929 +167
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/dataframe/partitionings.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvcGFydGl0aW9uaW5ncy5weQ==) | `91.30% <0.00%> (-4.49%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RpcmVjdC90ZXN0X3N0cmVhbV9pbXBsLnB5) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...uild/srcs/sdks/python/apache\_beam/internal/util.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pbnRlcm5hbC91dGlsLnB5) | `95.55% <0.00%> (-2.12%)` | :arrow_down: |
| [...cs/sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvZnJhbWVfYmFzZS5weQ==) | `89.65% <0.00%> (-1.98%)` | :arrow_down: |
| [...srcs/sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9tZXRyaWNzL21ldHJpY2Jhc2UucHk=) | `90.38% <0.00%> (-1.62%)` | :arrow_down: |
| [...sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2Vudmlyb25tZW50cy5weQ==) | `86.32% <0.00%> (-1.61%)` | :arrow_down: |
| [.../srcs/sdks/python/apache\_beam/transforms/window.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL3dpbmRvdy5weQ==) | `85.97% <0.00%> (-1.29%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/internal/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pbnRlcm5hbC9tZXRyaWNzL2NlbGxzLnB5) | `73.56% <0.00%> (-1.14%)` | :arrow_down: |
| [.../sdks/python/apache\_beam/options/value\_provider.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9vcHRpb25zL3ZhbHVlX3Byb3ZpZGVyLnB5) | `91.76% <0.00%> (-1.01%)` | :arrow_down: |
| [...uild/srcs/sdks/python/apache\_beam/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9tZXRyaWNzL2NlbGxzLnB5) | `81.32% <0.00%> (-1.01%)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...112c843](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-815280413
It seems like this PR is blocked by the timeout java precommit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-812203018
retest all please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on a change in pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on a change in pull request #14384:
URL: https://github.com/apache/beam/pull/14384#discussion_r605265836
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.pubsub;
+
+import com.google.auto.service.AutoService;
+import java.util.Collections;
+import java.util.Map;
+import org.apache.beam.model.pipeline.v1.RunnerApi;
+import org.apache.beam.model.pipeline.v1.RunnerApi.FunctionSpec;
+import org.apache.beam.model.pipeline.v1.RunnerApi.PubSubReadPayload;
+import org.apache.beam.model.pipeline.v1.RunnerApi.PubSubWritePayload;
+import org.apache.beam.runners.core.construction.PTransformTranslation;
+import org.apache.beam.runners.core.construction.PTransformTranslation.TransformPayloadTranslator;
+import org.apache.beam.runners.core.construction.SdkComponents;
+import org.apache.beam.runners.core.construction.TransformPayloadTranslatorRegistrar;
+import org.apache.beam.sdk.io.Read;
+import org.apache.beam.sdk.io.Read.Unbounded;
+import org.apache.beam.sdk.io.gcp.pubsub.PubsubClient.SubscriptionPath;
+import org.apache.beam.sdk.io.gcp.pubsub.PubsubClient.TopicPath;
+import org.apache.beam.sdk.io.gcp.pubsub.PubsubUnboundedSource.PubsubSource;
+import org.apache.beam.sdk.options.ValueProvider;
+import org.apache.beam.sdk.options.ValueProvider.NestedValueProvider;
+import org.apache.beam.sdk.runners.AppliedPTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+
+@SuppressWarnings({
+ "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+ "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+})
+/**
+ * Utility methods for translating a {@link Unbounded} which reads from {@link
+ * PubsubUnboundedSource} to {@link RunnerApi} representations.
+ */
+public class PubSubPayloadTranslation {
Review comment:
We have to put this translation logic in pubsub pkg instead of runner-core-construction because of circular dependency introduced by expansion services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ython/apache\_beam/runners/direct/bundle\_factory.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RpcmVjdC9idW5kbGVfZmFjdG9yeS5weQ==) | | |
| [...ild/srcs/sdks/python/apache\_beam/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9tZXRyaWNzL21ldHJpYy5weQ==) | | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvc3RhbmRhcmRfd2luZG93X2Zuc19wYjJfdXJucy5weQ==) | | |
| [...x/py38/build/srcs/sdks/python/apache\_beam/error.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9lcnJvci5weQ==) | | |
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93X3J1bm5lci5weQ==) | | |
| [.../srcs/sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zcWxfdGF4aS5weQ==) | | |
| [...cs/sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9zb3VyY2VfdGVzdF91dGlscy5weQ==) | | |
| [...ld/srcs/sdks/python/apache\_beam/coders/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9jb2RlcnMvX19pbml0X18ucHk=) | | |
| [...python/apache\_beam/typehints/typehints\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvdHlwZWhpbnRzX3Rlc3RfcHkzLnB5) | | |
| [...sdks/python/apache\_beam/dataframe/partitionings.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvcGFydGl0aW9uaW5ncy5weQ==) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-813554447
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...740616b](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 740616b differs from pull request most recent head 82e2074. Consider uploading reports for the commit 82e2074 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...82e2074](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RpcmVjdC90ZXN0X3N0cmVhbV9pbXBsLnB5) | | |
| [...8/build/srcs/sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9raW5lc2lzLnB5) | | |
| [...cs/sdks/python/apache\_beam/io/external/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9leHRlcm5hbC9fX2luaXRfXy5weQ==) | | |
| [...ks/python/apache\_beam/runners/worker/statecache.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zdGF0ZWNhY2hlLnB5) | | |
| [...on/apache\_beam/runners/portability/spark\_runner.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L3NwYXJrX3J1bm5lci5weQ==) | | |
| [...thon/apache\_beam/testing/metric\_result\_matchers.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL21ldHJpY19yZXN1bHRfbWF0Y2hlcnMucHk=) | | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfcmVhZF9pbnRlcm5hbC5weQ==) | | |
| [...e\_beam/portability/api/beam\_interactive\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvYmVhbV9pbnRlcmFjdGl2ZV9hcGlfcGIyLnB5) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query6.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9xdWVyaWVzL3F1ZXJ5Ni5weQ==) | | |
| [...ransforms/transforms\_keyword\_only\_args\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL3RyYW5zZm9ybXNfa2V5d29yZF9vbmx5X2FyZ3NfdGVzdF9weTMucHk=) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (1948f70) into [master](https://codecov.io/gh/apache/beam/commit/10f5cbc6d7eb6de41c24b13471390588b1dd2b1c?el=desc) (10f5cbc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.16% 83.14% -0.02%
==========================================
Files 469 469
Lines 58914 58914
==========================================
- Hits 48993 48985 -8
- Misses 9921 9929 +8
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e\_beam/examples/complete/juliaset/juliaset\_main.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXRfbWFpbi5weQ==) | | |
| [...cs/sdks/python/apache\_beam/io/gcp/gcsfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2ZpbGVzeXN0ZW0ucHk=) | | |
| [...srcs/sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | | |
| [...ild/srcs/sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | | |
| [...m/testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL21vZGVsLnB5) | | |
| [...s/python/apache\_beam/runners/worker/log\_handler.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvbG9nX2hhbmRsZXIucHk=) | | |
| [.../srcs/sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvdG9fdXRpbHMucHk=) | | |
| [...s/python/apache\_beam/portability/api/schema\_pb2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3NjaGVtYV9wYjIucHk=) | | |
| [...srcs/sdks/python/apache\_beam/io/gcp/dicomclient.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RpY29tY2xpZW50LnB5) | | |
| [...ild/srcs/sdks/python/apache\_beam/io/gcp/dicomio.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RpY29taW8ucHk=) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [10f5cbc...1948f70](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...cs/sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9kYXRhZnJhbWUvZnJhbWVfYmFzZS5weQ==) | | |
| [...amples/snippets/transforms/aggregation/distinct.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL2Rpc3RpbmN0LnB5) | | |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L2ZuX2FwaV9ydW5uZXIvdHJhbnNsYXRpb25zLnB5) | | |
| [...build/srcs/sdks/python/apache\_beam/testing/util.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL3V0aWwucHk=) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9xdWVyaWVzL3F1ZXJ5My5weQ==) | | |
| [...examples/snippets/transforms/elementwise/kvswap.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2VsZW1lbnR3aXNlL2t2c3dhcC5weQ==) | | |
| [...python/apache\_beam/examples/wordcount\_debugging.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy93b3JkY291bnRfZGVidWdnaW5nLnB5) | | |
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | | |
| [...hon/apache\_beam/portability/api/schema\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvc2NoZW1hX3BiMl9ncnBjLnB5) | | |
| [.../srcs/sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9jb2RlcnMvdHlwZWNvZGVycy5weQ==) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-813499423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-813499728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...m/examples/snippets/transforms/elementwise/keys.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2VsZW1lbnR3aXNlL2tleXMucHk=) | | |
| [...x/py38/build/srcs/sdks/python/apache\_beam/error.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9lcnJvci5weQ==) | | |
| [...python/apache\_beam/transforms/external\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2V4dGVybmFsX3Rlc3RfcHkzLnB5) | | |
| [...build/srcs/sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvZ2NzaW8ucHk=) | | |
| [...\_beam/io/gcp/datastore/v1new/adaptive\_throttler.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvZGF0YXN0b3JlL3YxbmV3L2FkYXB0aXZlX3Rocm90dGxlci5weQ==) | | |
| [...hon/apache\_beam/examples/complete/game/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9jb21wbGV0ZS9nYW1lL19faW5pdF9fLnB5) | | |
| [...python/apache\_beam/examples/wordcount\_debugging.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy93b3JkY291bnRfZGVidWdnaW5nLnB5) | | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvYmVhbV9qb2JfYXBpX3BiMl9ncnBjLnB5) | | |
| [...ild/srcs/sdks/python/apache\_beam/runners/runner.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3J1bm5lci5weQ==) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query0.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90ZXN0aW5nL2JlbmNobWFya3MvbmV4bWFyay9xdWVyaWVzL3F1ZXJ5MC5weQ==) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [WIP] Changes PubSub translation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (740616b) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.02%
==========================================
Files 470 470
Lines 59001 59063 +62
==========================================
+ Hits 49239 49279 +40
- Misses 9762 9784 +22
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfZmlsZV9sb2Fkcy5weQ==) | `86.60% <0.00%> (-4.51%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9pb2Jhc2UucHk=) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...s/sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvYmlncXVlcnlfdG9vbHMucHk=) | `88.05% <0.00%> (-0.04%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9zZGtfd29ya2VyLnB5) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5) | `93.86% <0.00%> (+0.25%)` | :arrow_up: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9sb2NhbGZpbGVzeXN0ZW0ucHk=) | `92.36% <0.00%> (+0.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...740616b](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-810684093
# [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=h1) Report
> Merging [#14384](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=desc) (bbce792) into [master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc) (93a6927) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14384 +/- ##
==========================================
- Coverage 83.45% 83.42% -0.03%
==========================================
Files 470 463 -7
Lines 59001 59013 +12
==========================================
- Hits 49239 49233 -6
- Misses 9762 9780 +18
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ache\_beam/examples/snippets/transforms/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL19faW5pdF9fLnB5) | | |
| [...gcp/datastore/v1new/datastore\_write\_it\_pipeline.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvZGF0YXN0b3JlL3YxbmV3L2RhdGFzdG9yZV93cml0ZV9pdF9waXBlbGluZS5weQ==) | | |
| [.../runners/interactive/testing/pipeline\_assertion.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3Rlc3RpbmcvcGlwZWxpbmVfYXNzZXJ0aW9uLnB5) | | |
| [...snippets/transforms/aggregation/combineglobally.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL2NvbWJpbmVnbG9iYWxseS5weQ==) | | |
| [...python/apache\_beam/transforms/external\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2V4dGVybmFsX3Rlc3RfcHkzLnB5) | | |
| [...\_beam/runners/interactive/user\_pipeline\_tracker.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2ludGVyYWN0aXZlL3VzZXJfcGlwZWxpbmVfdHJhY2tlci5weQ==) | | |
| [.../python/apache\_beam/portability/api/metrics\_pb2.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvbWV0cmljc19wYjIucHk=) | | |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pby9nY3AvaW50ZXJuYWwvY2xpZW50cy9zdG9yYWdlL19faW5pdF9fLnB5) | | |
| [...amples/snippets/transforms/aggregation/distinct.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9leGFtcGxlcy9zbmlwcGV0cy90cmFuc2Zvcm1zL2FnZ3JlZ2F0aW9uL2Rpc3RpbmN0LnB5) | | |
| [...ython/apache\_beam/typehints/decorators\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90eXBlaGludHMvZGVjb3JhdG9yc190ZXN0X3B5My5weQ==) | | |
| ... and [923 more](https://codecov.io/gh/apache/beam/pull/14384/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=footer). Last update [288d379...bbce792](https://codecov.io/gh/apache/beam/pull/14384?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-811639366
Java precommit looks bad. But I wanted to LGTM from the basic code review and trust you can work out the details. I can take a closer look again if you let me know when is a good time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-812075611
Please take another look @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-812634113
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14384:
URL: https://github.com/apache/beam/pull/14384#issuecomment-814297917
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org