svn commit: r1889773 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java

[ti...@apache.org]

Author: tilman
Date: Tue May 11 18:47:23 2021
New Revision: 1889773

URL: http://svn.apache.org/viewvc?rev=1889773&view=rev
Log:
PDFBOX-4892: revert and add comment instead

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java?rev=1889773&r1=1889772&r2=1889773&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java Tue May 11 18:47:23 2021
@@ -52,15 +52,13 @@ class ShadedTriangle
     /**
      * Constructor.
      *
-     * @param p an array of the 3 vertices of a triangle
+     * @param p an array of the 3 vertices of a triangle; the Point2D objects should not be modified
+     * by the caller.
      * @param c an array of color corresponding the vertex array p
      */
     ShadedTriangle(Point2D[] p, float[][] c)
     {
-        corner = new Point2D[3];
-        corner[0] = (Point2D) p[0].clone();
-        corner[1] = (Point2D) p[1].clone();
-        corner[2] = (Point2D) p[2].clone();
+        corner = p.clone(); // yes this is a shallow clone
         color = c.clone();
         area = getArea(p[0], p[1], p[2]);
         degree = calcDeg(p);