You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/21 18:20:47 UTC
svn commit: r1697022 -
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java
Author: sebb
Date: Fri Aug 21 16:20:47 2015
New Revision: 1697022
URL: http://svn.apache.org/r1697022
Log:
FindBugs: String append in a loop
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java?rev=1697022&r1=1697021&r2=1697022&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/Subroutines.java Fri Aug 21 16:20:47 2015
@@ -115,24 +115,27 @@ public class Subroutines{
*/
@Override
public String toString(){
- String ret = "Subroutine: Local variable is '"+localVariable+
- "', JSRs are '"+theJSRs+"', RET is '"+theRET+"', Instructions: '"+instructions+"'.";
+ StringBuilder ret = new StringBuilder();
+ ret.append("Subroutine: Local variable is '").append(localVariable);
+ ret.append("', JSRs are '").append(theJSRs);
+ ret.append("', RET is '").append(theRET);
+ ret.append("', Instructions: '").append(instructions).append("'.");
- ret += " Accessed local variable slots: '";
+ ret.append(" Accessed local variable slots: '");
int[] alv = getAccessedLocalsIndices();
for (int element : alv) {
- ret += element+" ";
+ ret.append(element);ret.append(" ");
}
- ret+="'.";
+ ret.append("'.");
- ret += " Recursively (via subsub...routines) accessed local variable slots: '";
+ ret.append(" Recursively (via subsub...routines) accessed local variable slots: '");
alv = getRecursivelyAccessedLocalsIndices();
for (int element : alv) {
- ret += element+" ";
+ ret.append(element);ret.append(" ");
}
- ret+="'.";
+ ret.append("'.");
- return ret;
+ return ret.toString();
}
/**