[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6473: Fix backup dates

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on code in PR #6473:
URL: https://github.com/apache/cloudstack/pull/6473#discussion_r928353781


##########
engine/schema/src/main/resources/META-INF/db/schema-41710to41800.sql:
##########
@@ -22,4 +22,11 @@
 -- Enable CPU cap for default system offerings;
 UPDATE `cloud`.`service_offering` so
 SET so.limit_cpu_use = 1
-WHERE so.default_use = 1 AND so.vm_type IN ('domainrouter', 'secondarystoragevm', 'consoleproxy', 'internalloadbalancervm', 'elasticloadbalancervm');
\ No newline at end of file
+WHERE so.default_use = 1 AND so.vm_type IN ('domainrouter', 'secondarystoragevm', 'consoleproxy', 'internalloadbalancervm', 'elasticloadbalancervm');
+
+-- Drop all backup records and change date column type to DATETIME. The data will be resynchronized automatically later;
+DELETE FROM `cloud`.`backups`

Review Comment:
   @JoaoJandre I see your point that even if these backups are deleted from the database, the management server will again sync and get all the backups from Veeam. But instead of losing the history of backups, it is better to modify the date. You can use java upgrade file Upgrade417100to418000.java file to do that.
   
   By deleting the entries we will also lose the history of removed backups.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org