You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Robert McGuinness (Created) (JIRA)" <ji...@apache.org> on 2012/01/08 20:11:40 UTC
[jira] [Created] (WICKET-4328)
JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
----------------------------------------------------------------------
Key: WICKET-4328
URL: https://issues.apache.org/jira/browse/WICKET-4328
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 6.0.0
Reporter: Robert McGuinness
http://apache-wicket.1842946.n4.nabble.com/Wicket-6-0-JavaScriptFilteredIntoFooterHeaderResponse-CssHeaderItem-td4274687.html
The default JavaScriptFilteredIntoFooterHeaderResponse seems too restrictive by only accepting CssHeaderItem types in the header bucket and filtering everything else into the footer bucket. Components contributing to meta tags for example, get filtered into the footer bucket in the current design. Also, some javascript resources need to live in the header bucket for functionality (modernizr.js, etc).
Food for thought: maybe allow types of HeaderItem to accept an IHeaderResponseFilter as a target when building resources. Ex:
response.render(JavaScriptReferenceHeaderItem.forReference(new JavaScriptResourceReference(AssetsInception.class, "modernizr-custom.js").in(FooterAcceptingResponseFilter.class));
then the "accepts" method of the FooterAcceptingResponseFilter can check if the HeaderItem should accepted or denied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4328)
JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
Posted by "Emond Papegaaij (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4328.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
The JavaScriptFilteredIntoFooterHeaderResponse has been changed, taking your improvements into account. It puts both css and page header items at the top. For javascript, a special FilteredHeaderItem has been created, which takes the filter name where it should be placed. See the resource decoration example on how this works.
> JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
> ----------------------------------------------------------------------
>
> Key: WICKET-4328
> URL: https://issues.apache.org/jira/browse/WICKET-4328
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Robert McGuinness
> Assignee: Emond Papegaaij
> Fix For: 6.0.0
>
> Attachments: FooterAcceptingResponseFilter.java, HeaderAcceptingResponseFilter.java, InceptionFilteredHeaderResponse.java, JavaScriptReferenceInHeaderItem.java
>
>
> http://apache-wicket.1842946.n4.nabble.com/Wicket-6-0-JavaScriptFilteredIntoFooterHeaderResponse-CssHeaderItem-td4274687.html
> The default JavaScriptFilteredIntoFooterHeaderResponse seems too restrictive by only accepting CssHeaderItem types in the header bucket and filtering everything else into the footer bucket. Components contributing to meta tags for example, get filtered into the footer bucket in the current design. Also, some javascript resources need to live in the header bucket for functionality (modernizr.js, etc).
> Food for thought: maybe allow types of HeaderItem to accept an IHeaderResponseFilter as a target when building resources. Ex:
> response.render(JavaScriptReferenceHeaderItem.forReference(new JavaScriptResourceReference(AssetsInception.class, "modernizr-custom.js").in(FooterAcceptingResponseFilter.class));
> then the "accepts" method of the FooterAcceptingResponseFilter can check if the HeaderItem should accepted or denied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4328)
JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
Posted by "Robert McGuinness (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert McGuinness updated WICKET-4328:
--------------------------------------
Attachment: JavaScriptReferenceInHeaderItem.java
InceptionFilteredHeaderResponse.java
HeaderAcceptingResponseFilter.java
FooterAcceptingResponseFilter.java
These are the custom classes I used to solve the restrictive nature of JavaScriptFilteredIntoFooterHeaderResponse.
> JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
> ----------------------------------------------------------------------
>
> Key: WICKET-4328
> URL: https://issues.apache.org/jira/browse/WICKET-4328
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Robert McGuinness
> Attachments: FooterAcceptingResponseFilter.java, HeaderAcceptingResponseFilter.java, InceptionFilteredHeaderResponse.java, JavaScriptReferenceInHeaderItem.java
>
>
> http://apache-wicket.1842946.n4.nabble.com/Wicket-6-0-JavaScriptFilteredIntoFooterHeaderResponse-CssHeaderItem-td4274687.html
> The default JavaScriptFilteredIntoFooterHeaderResponse seems too restrictive by only accepting CssHeaderItem types in the header bucket and filtering everything else into the footer bucket. Components contributing to meta tags for example, get filtered into the footer bucket in the current design. Also, some javascript resources need to live in the header bucket for functionality (modernizr.js, etc).
> Food for thought: maybe allow types of HeaderItem to accept an IHeaderResponseFilter as a target when building resources. Ex:
> response.render(JavaScriptReferenceHeaderItem.forReference(new JavaScriptResourceReference(AssetsInception.class, "modernizr-custom.js").in(FooterAcceptingResponseFilter.class));
> then the "accepts" method of the FooterAcceptingResponseFilter can check if the HeaderItem should accepted or denied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4328)
JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
Posted by "Martin Grigorov (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4328:
---------------------------------------
Assignee: Martin Grigorov
> JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
> ----------------------------------------------------------------------
>
> Key: WICKET-4328
> URL: https://issues.apache.org/jira/browse/WICKET-4328
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Robert McGuinness
> Assignee: Martin Grigorov
> Attachments: FooterAcceptingResponseFilter.java, HeaderAcceptingResponseFilter.java, InceptionFilteredHeaderResponse.java, JavaScriptReferenceInHeaderItem.java
>
>
> http://apache-wicket.1842946.n4.nabble.com/Wicket-6-0-JavaScriptFilteredIntoFooterHeaderResponse-CssHeaderItem-td4274687.html
> The default JavaScriptFilteredIntoFooterHeaderResponse seems too restrictive by only accepting CssHeaderItem types in the header bucket and filtering everything else into the footer bucket. Components contributing to meta tags for example, get filtered into the footer bucket in the current design. Also, some javascript resources need to live in the header bucket for functionality (modernizr.js, etc).
> Food for thought: maybe allow types of HeaderItem to accept an IHeaderResponseFilter as a target when building resources. Ex:
> response.render(JavaScriptReferenceHeaderItem.forReference(new JavaScriptResourceReference(AssetsInception.class, "modernizr-custom.js").in(FooterAcceptingResponseFilter.class));
> then the "accepts" method of the FooterAcceptingResponseFilter can check if the HeaderItem should accepted or denied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4328)
JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
Posted by "Emond Papegaaij (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij reassigned WICKET-4328:
---------------------------------------
Assignee: Emond Papegaaij (was: Martin Grigorov)
> JavaScriptFilteredIntoFooterHeaderResponse + CssHeaderItem Enhancement
> ----------------------------------------------------------------------
>
> Key: WICKET-4328
> URL: https://issues.apache.org/jira/browse/WICKET-4328
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Robert McGuinness
> Assignee: Emond Papegaaij
> Attachments: FooterAcceptingResponseFilter.java, HeaderAcceptingResponseFilter.java, InceptionFilteredHeaderResponse.java, JavaScriptReferenceInHeaderItem.java
>
>
> http://apache-wicket.1842946.n4.nabble.com/Wicket-6-0-JavaScriptFilteredIntoFooterHeaderResponse-CssHeaderItem-td4274687.html
> The default JavaScriptFilteredIntoFooterHeaderResponse seems too restrictive by only accepting CssHeaderItem types in the header bucket and filtering everything else into the footer bucket. Components contributing to meta tags for example, get filtered into the footer bucket in the current design. Also, some javascript resources need to live in the header bucket for functionality (modernizr.js, etc).
> Food for thought: maybe allow types of HeaderItem to accept an IHeaderResponseFilter as a target when building resources. Ex:
> response.render(JavaScriptReferenceHeaderItem.forReference(new JavaScriptResourceReference(AssetsInception.class, "modernizr-custom.js").in(FooterAcceptingResponseFilter.class));
> then the "accepts" method of the FooterAcceptingResponseFilter can check if the HeaderItem should accepted or denied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira