[I] Add regression coverage for legacy alert rule payload normalization [rocketmq-dashboard]

["btlqql (via GitHub)" <gi...@apache.org>]

btlqql opened a new issue, #4028:
URL: https://github.com/apache/rocketmq-dashboard/issues/4028

   ## Problem
   The current test suite does not cover legacy alert rule payload normalization.
   
   ## Expected behavior
   - A focused Vitest case locks the existing behavior.
   - The targeted test file passes and fails if the covered behavior regresses.
   
   ## Scope
   Only add regression coverage for $(@{Slug=alert-rule-payload; Focus=legacy alert rule payload normalization; PrTitle=test(alert-rules): cover legacy payload normalization; TestFile=web/src/pages/ops/__tests__/alertRulePayload.test.ts; Mode=new; Append=/*
    * Licensed to the Apache Software Foundation (ASF) under one or more
    * contributor license agreements.  See the NOTICE file distributed with
    * this work for additional information regarding copyright ownership.
    * The ASF licenses this file to You under the Apache License, Version 2.0
    * (the "License"); you may not use this file except in compliance with
    * the License.  You may obtain a copy of the License at
    *
    *     http://www.apache.org/licenses/LICENSE-2.0
    *
    * Unless required by applicable law or agreed to in writing, software
    * distributed under the License is distributed on an "AS IS" BASIS,
    * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    * See the License for the specific language governing permissions and
    * limitations under the License.
    */
   
   import { describe, expect, it } from 'vitest';
   import {
     attachThresholdUnit,
     normalizeDuration,
     normalizeMetric,
     thresholdUnits,
   } from '../alertRulePayload';
   
   describe('alert rule payload normalization', () => {
     it('maps legacy Chinese metric labels to Prometheus metric names', () => {
       expect(normalizeMetric('磁盘使用率')).toBe('rocketmq_disk_use_ratio');
       expect(normalizeMetric('rocketmq_tps')).toBe('rocketmq_tps');
     });
   
     it('maps legacy Chinese duration labels to Prometheus durations', () => {
       expect(normalizeDuration('1分钟')).toBe('1m');
       expect(normalizeDuration('30分钟')).toBe('30m');
       expect(normalizeDuration('45分钟')).toBe('45分钟');
     });
   
     it('attaches the metric threshold unit after normalization', () => {
       expect(
         attachThresholdUnit({ metric: '磁盘使用率', duration: '1分钟', threshold: 80 }),
       ).toEqual({
         metric: 'rocketmq_disk_use_ratio',
         duration: '1m',
         threshold: 80,
         thresholdUnit: '%',
       });
       expect(thresholdUnits['rocketmq_consumer_lag_messages']).toBe('条');
     });
   });}.TestFile). No runtime behavior changes.
   
   ## Acceptance criteria
   - [ ] The targeted Vitest file passes.
   - [ ] git diff --check is clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add regression coverage for legacy alert rule payload normalization [rocketmq-dashboard]

["RockteMQ-AI (via GitHub)" <gi...@apache.org>]

RockteMQ-AI commented on issue #4028:
URL: https://github.com/apache/rocketmq-dashboard/issues/4028#issuecomment-5564486607

   **Issue Evaluation**
   
   Category: `enhancement` | Status: **Evaluated**
   
   **Feasibility:** feasible
   **Scope:** Test suite — frontend regression coverage
   **Compatibility:** No breaking changes
   
   This is a well-scoped test coverage improvement request. Adding focused Vitest regression cases for the specified behavior will help prevent future regressions and improve overall code quality.
   
   **Assessment:** The issue clearly defines the expected behavior and target test file. This is a good candidate for community contribution.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add regression coverage for legacy alert rule payload normalization [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins commented on issue #4028:
URL: https://github.com/apache/rocketmq-dashboard/issues/4028#issuecomment-6077351735

   Resolved by #5437 (merged into `rocketmq-studio` as 01bf7ec3f); the fix was contributed in #5447, which we folded into that change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add regression coverage for legacy alert rule payload normalization [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed issue #4028: Add regression coverage for legacy alert rule payload normalization
URL: https://github.com/apache/rocketmq-dashboard/issues/4028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org