You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/19 14:27:21 UTC

[GitHub] [iceberg] pvary opened a new pull request, #6452: Flink: Improve IcebergFilesCommitter logging

pvary opened a new pull request, #6452:
URL: https://github.com/apache/iceberg/pull/6452

   Add some logging to the `IcebergFilesCommitter`. Otherwise it is hard to follow what happens when multiple commits are in progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] pvary commented on pull request #6452: Flink: Improve IcebergFilesCommitter logging

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6452:
URL: https://github.com/apache/iceberg/pull/6452#issuecomment-1361055791

   Merged to master.
   Thanks for the review @rdblue and @stevenzwu!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on a diff in pull request #6452: Flink: Improve IcebergFilesCommitter logging

Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6452:
URL: https://github.com/apache/iceberg/pull/6452#discussion_r1052515720


##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -372,9 +382,10 @@ private void commitOperation(
     operation.commit(); // abort is automatically called if this fails.
     long durationMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNano);
     LOG.info(
-        "Committed {} to table {} in {} ms with summary: {}",
+        "Committed {} to table: {}, checkpointId {} in {} ms with summary: {}",

Review Comment:
   Can we remove the summary? We don't need to log it twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] pvary merged pull request #6452: Flink: Improve IcebergFilesCommitter logging

Posted by GitBox <gi...@apache.org>.
pvary merged PR #6452:
URL: https://github.com/apache/iceberg/pull/6452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6452: Flink: Improve IcebergFilesCommitter logging

Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #6452:
URL: https://github.com/apache/iceberg/pull/6452#discussion_r1052918822


##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -361,7 +366,12 @@ private void commitOperation(
       String description,
       String newFlinkJobId,
       long checkpointId) {
-    LOG.info("Committing {} to table {} with summary: {}", description, table.name(), summary);
+    LOG.info(
+        "Committing {} to table: {}, checkpointId: {} with summary: {}",

Review Comment:
   the log message doesn't read quite naturally. 
   
   here is one alternative
   ```
   LOG.info("Committing {} for checkpoint {} to table{} with summary: {}", description, checkpointId, table.name(), summary)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org