You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2016/02/10 18:23:24 UTC
[GitHub] curator pull request: Don't allow NamespaceWatcher to compare equa...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/134
Don't allow NamespaceWatcher to compare equal to a raw Watcher
Don't allow NamespaceWatcher to compare equal to a raw Watcher or CuratorWatcher. It can't be done reciprocally in a raw Watcher and is actually unnecessary. NOTE: a Curator Tech Note should be written to warn that Watchers are wrapped internally
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator namespace-watcher-equality-change
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit 5fb194fcc7a1fa9d7e409a511177a3098a32d0dd
Author: randgalt <ra...@apache.org>
Date: 2016-02-10T17:22:24Z
Don't allow NamespaceWatcher to compare equal to a raw Watcher or CuratorWatcher. It can't be done reciprocally in a raw Watcher and is actually unnecessary. NOTE: a Curator Tech Note should be written to warn that Watchers are wrapped internally
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: Don't allow NamespaceWatcher to compare equa...
Posted by dragonsinth <gi...@git.apache.org>.
Github user dragonsinth commented on the pull request:
https://github.com/apache/curator/pull/134#issuecomment-182498876
There will be a test failure, see https://github.com/apache/curator/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: Don't allow NamespaceWatcher to compare equa...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt closed the pull request at:
https://github.com/apache/curator/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: Don't allow NamespaceWatcher to compare equa...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/134#issuecomment-182505261
Closing in favor of #135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---